Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2774453002: Remove enbale_xpc_notifications compile flag (Closed)

Created:
3 years, 9 months ago by Miguel Garcia
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek, Nico
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enbale_xpc_notifications compile flag BUG=571056 Review-Url: https://codereview.chromium.org/2774453002 Cr-Commit-Position: refs/heads/master@{#462555} Committed: https://chromium.googlesource.com/chromium/src/+/10c2dce446228965cfbc848f8a8f7fadccaf6f02

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -93 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/BUILD.gn View 1 9 chunks +16 lines, -35 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 1 4 chunks +1 line, -38 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm View 1 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/features.gni View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Miguel Garcia
3 years, 9 months ago (2017-03-22 22:19:45 UTC) #4
Robert Sesek
LGTM
3 years, 9 months ago (2017-03-22 22:39:45 UTC) #5
Miguel Garcia
+Nico for owners I foolishly made this depend on https://codereview.chromium.org/2709213005 Robert if you can have ...
3 years, 9 months ago (2017-03-23 17:42:30 UTC) #9
Nico
lgtm
3 years, 9 months ago (2017-03-23 18:08:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774453002/20001
3 years, 8 months ago (2017-04-06 12:39:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/243587)
3 years, 8 months ago (2017-04-06 12:52:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774453002/20001
3 years, 8 months ago (2017-04-06 16:54:26 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:38:36 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/10c2dce446228965cfbc848f8a8f...

Powered by Google App Engine
This is Rietveld 408576698