Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: BUILD.gn

Issue 2774453002: Remove enbale_xpc_notifications compile flag (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 if (target_cpu != "arm") { 510 if (target_cpu != "arm") {
511 deps += [ "//gpu/tools/compositor_model_bench" ] 511 deps += [ "//gpu/tools/compositor_model_bench" ]
512 } 512 }
513 } 513 }
514 } 514 }
515 515
516 if (is_mac) { 516 if (is_mac) {
517 deps += [ 517 deps += [
518 "//breakpad:crash_inspector", 518 "//breakpad:crash_inspector",
519 "//breakpad:dump_syms", 519 "//breakpad:dump_syms",
520
521 # XPC service is in developement and guarded against the
522 # enable_xpc_notifications, in the meantime however we still
523 # need compile coverage in the bots.
524 "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
525 "//third_party/apple_sample_code", 520 "//third_party/apple_sample_code",
526 "//third_party/molokocacao", 521 "//third_party/molokocacao",
527 ] 522 ]
528 deps -= [ 523 deps -= [
529 # Mojo in GN contains some things which are never compiled in GYP on Mac, 524 # Mojo in GN contains some things which are never compiled in GYP on Mac,
530 # so compilation fails on Mac. They need porting. 525 # so compilation fails on Mac. They need porting.
531 "//mojo", 526 "//mojo",
532 ] 527 ]
533 } 528 }
534 529
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 assert(target_name != "") # Mark as used. 1089 assert(target_name != "") # Mark as used.
1095 sources = invoker.actual_sources 1090 sources = invoker.actual_sources
1096 assert( 1091 assert(
1097 sources == invoker.actual_sources, 1092 sources == invoker.actual_sources,
1098 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1093 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1099 } 1094 }
1100 1095
1101 assert_valid_out_dir("_unused") { 1096 assert_valid_out_dir("_unused") {
1102 actual_sources = [ "$root_build_dir/foo" ] 1097 actual_sources = [ "$root_build_dir/foo" ]
1103 } 1098 }
OLDNEW
« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698