Add COMPONENT and TEAM to sensors API OWNERS files

Add COMPONENT and TEAM to sensors API OWNERS files

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor and Blink>Sensor>DeviceOrientation
components and device-dev@chromium.org team mailing list.

BUG=None

Review-Url: https://codereview.chromium.org/2774433002
Cr-Commit-Position: refs/heads/master@{#471050}
Committed: https://chromium.googlesource.com/chromium/src/+/8c4e6ca1e9ffd25f04505b1e451cf26e19c8101c

[Reilly Grant (use Gerrit), 2017-03-22 20:55:14]

reillyg@chromium.org changed reviewers:
+ timvolodine@chromium.org

[Reilly Grant (use Gerrit), 2017-03-22 20:55:14]

Please take a look. Note, I have created a Blink>DeviceOrientation component in
order to separate bugs in our web platform implementation from bugs in our
platform code for reading data from sensors, which go in IO>DeviceOrientation.

[Reilly Grant (use Gerrit), 2017-03-28 19:35:40]

Friendly ping.

[timvolodine, 2017-03-29 16:39:13]

https://codereview.chromium.org/2774433002/diff/1/device/generic_sensor/OWNERS
File device/generic_sensor/OWNERS (right):

https://codereview.chromium.org/2774433002/diff/1/device/generic_sensor/OWNER...
device/generic_sensor/OWNERS:5: # COMPONENT: IO>DeviceOrientation
Should we have a separate component for generic_sensors? Ideally a component
structure like Sensors>Generic, Sensors>DeviceOrientation, .. would perhaps be
more appropriate..

https://codereview.chromium.org/2774433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/device_orientation/OWNERS (right):

https://codereview.chromium.org/2774433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/OWNERS:3: # COMPONENT:
Blink>DeviceOrientation
The (IO|Blink)>DeviceOrientation seems somewhat confusing (or too verbose),
maybe just keep one? (i.e. IO>DeviceOrientation).

[Reilly Grant (use Gerrit), 2017-03-30 22:16:03]

https://codereview.chromium.org/2774433002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/device_orientation/OWNERS (right):

https://codereview.chromium.org/2774433002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/OWNERS:3: # COMPONENT:
Blink>DeviceOrientation
On 2017/03/29 16:39:13, timvolodine wrote:
> The (IO|Blink)>DeviceOrientation seems somewhat confusing (or too verbose),
> maybe just keep one? (i.e. IO>DeviceOrientation).

The reason for the IO/Blink separation is that the IO>Foo component captures
bugs in the platform-specific code use for (in this case) accessing sensors
which might be used by multiple components of Chrome, while the Blink>Foo
component captures bugs in the implementation of the Foo web API. I established
this pattern when maintaining //device/usb, the WebUSB API and the chrome.usb
API because it was useful to have separate components for issues that effected
communication with USB devices in general (since this code is consumed in a
number of places) compared to issues in a particular developer-facing API.

Since Generic Sensors is adding a number of new sensor types would you support
renaming the existing IO>DeviceOrientation and Blink>DeviceOrientation
components to IO>Sensors and Blink>Sensors? If you don't think that the
separation described above makes sense for sensors then we can merge IO>Sensors
into Blink>Sensors, which would cover all web platform sensor APIs.

[Reilly Grant (use Gerrit), 2017-05-03 23:29:41]

Description was changed from

==========
Assign sensors API ownership to the sensors-dev@chromium.org TEAM.

This change updates OWNERS files for device sensors-related directories
to point to the (IO|Blink)>DeviceOrientation components and
sensors-dev@chromium.org team mailing list.

BUG=None
==========

to

==========
Assign sensors API ownership to the device-dev@chromium.org TEAM.

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor component and device-dev@chromium.org team
mailing list.

BUG=None
==========

[Reilly Grant (use Gerrit), 2017-05-03 23:30:17]

Please take another look. I have done the consolidation into the Blink>Sensor
component.

[Reilly Grant (use Gerrit), 2017-05-03 23:30:42]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:31:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 00:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:55:53]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-05-05 18:06:20]

Hi Reilly, yes thanks, sorry this got a bit stale. The IO/Blink separation kind
of makes sense although not sure if it's easy to use. My main concern is to have
a separate component for DeviceOrientation/Motion as to distinguish from generic
sensors. Further it does look a bit weird that we include Blink>Sensors as
component in non-blink code, but I guess that's kind of historical.

https://codereview.chromium.org/2774433002/diff/20001/content/browser/device_...
File content/browser/device_sensors/OWNERS (right):

https://codereview.chromium.org/2774433002/diff/20001/content/browser/device_...
content/browser/device_sensors/OWNERS:3: # COMPONENT: Blink>Sensor
can we have a separate component for this to distinguish from generic_sensors
implementation. Maybe just keep IO>DeviceOrientaion?

https://codereview.chromium.org/2774433002/diff/20001/device/generic_sensor/O...
File device/generic_sensor/OWNERS (right):

https://codereview.chromium.org/2774433002/diff/20001/device/generic_sensor/O...
device/generic_sensor/OWNERS:5: # COMPONENT: Blink>Sensor
perhaps Blink>GenericSensor or Blink>GenericSensorAPI would be a better name?
also, would this be IO>GenericSensor since it's not in blink? or is this just to
point out the relevant API?

[Reilly Grant (use Gerrit), 2017-05-05 19:43:33]

Given your (and others') reaction to the IO/Blink split I recently merged this
and other components into a single entry under Blink when there were no
consumers of the code in //device other than Blink.

Is there value in separate components for Generic Sensors based APIs and the
DeviceOrientation Event API? I'm working with juncai@ to merge //device/sensors
and //device/generic_sensors so that we only have one implementation of the
platform specific pieces. I don't plan on creating separate components for the
Accelerometer, Gyroscope, etc. sensor APIs based on Generic Sensors and so I
think that separating out DeviceOrientation is also splitting hairs in a way
that will confuse people trying to file bugs.

[timvolodine, 2017-05-08 18:09:36]

On 2017/05/05 19:43:33, Reilly Grant wrote:
> Given your (and others') reaction to the IO/Blink split I recently merged this
> and other components into a single entry under Blink when there were no
> consumers of the code in //device other than Blink.
> 
> Is there value in separate components for Generic Sensors based APIs and the
> DeviceOrientation Event API? I'm working with juncai@ to merge
//device/sensors
> and //device/generic_sensors so that we only have one implementation of the
> platform specific pieces. I don't plan on creating separate components for the
> Accelerometer, Gyroscope, etc. sensor APIs based on Generic Sensors and so I
> think that separating out DeviceOrientation is also splitting hairs in a way
> that will confuse people trying to file bugs.

Thanks for the context. I was not aware of the 'merge' effort, is there a design
doc for merging /sensors and /generic_sensors? Regarding DeviceOrientation I
think it's nice to have a separate component for that as it is currently a
different implementation and also a different API/spec which is also supported
across multiple browsers.. If the user/developer encounters an issue with
DeviceOrientation I think it would be easier to triage into it's own component
and to address that way.

[Reilly Grant (use Gerrit), 2017-05-08 19:36:28]

On 2017/05/08 18:09:36, timvolodine wrote:
> On 2017/05/05 19:43:33, Reilly Grant wrote:
> > Given your (and others') reaction to the IO/Blink split I recently merged
this
> > and other components into a single entry under Blink when there were no
> > consumers of the code in //device other than Blink.
> > 
> > Is there value in separate components for Generic Sensors based APIs and the
> > DeviceOrientation Event API? I'm working with juncai@ to merge
> //device/sensors
> > and //device/generic_sensors so that we only have one implementation of the
> > platform specific pieces. I don't plan on creating separate components for
the
> > Accelerometer, Gyroscope, etc. sensor APIs based on Generic Sensors and so I
> > think that separating out DeviceOrientation is also splitting hairs in a way
> > that will confuse people trying to file bugs.
> 
> Thanks for the context. I was not aware of the 'merge' effort, is there a
design
> doc for merging /sensors and /generic_sensors? Regarding DeviceOrientation I
> think it's nice to have a separate component for that as it is currently a
> different implementation and also a different API/spec which is also supported
> across multiple browsers.. If the user/developer encounters an issue with
> DeviceOrientation I think it would be easier to triage into it's own component
> and to address that way.

Jun has been working on a design doc for this merge here:
https://docs.google.com/document/d/1aJo41_Md9XhinVLAI1O2m2cnla9GIK-AkQ5vj1iXu...

I've updated the patch to put the DeviceOrientation implementation in the
Blink>Sensor>DeviceOrientation component. Generic Sensors is still in the
Blink>Sensor component because there aren't separate directories for the various
new sensor classes like Accelerometer, OrientationSensor, etc. I don't feel that
Blink>Sensor>GenericSensor will make sense to issue reporters. If we create
components for these sensor types we can rearrange the source tree to make the
mapping clear.

If you approve this I will go ahead and create the necessary new components.

[timvolodine, 2017-05-11 17:13:41]

On 2017/05/08 19:36:28, Reilly Grant wrote:
> On 2017/05/08 18:09:36, timvolodine wrote:
> > On 2017/05/05 19:43:33, Reilly Grant wrote:
> > > Given your (and others') reaction to the IO/Blink split I recently merged
> this
> > > and other components into a single entry under Blink when there were no
> > > consumers of the code in //device other than Blink.
> > > 
> > > Is there value in separate components for Generic Sensors based APIs and
the
> > > DeviceOrientation Event API? I'm working with juncai@ to merge
> > //device/sensors
> > > and //device/generic_sensors so that we only have one implementation of
the
> > > platform specific pieces. I don't plan on creating separate components for
> the
> > > Accelerometer, Gyroscope, etc. sensor APIs based on Generic Sensors and so
I
> > > think that separating out DeviceOrientation is also splitting hairs in a
way
> > > that will confuse people trying to file bugs.
> > 
> > Thanks for the context. I was not aware of the 'merge' effort, is there a
> design
> > doc for merging /sensors and /generic_sensors? Regarding DeviceOrientation I
> > think it's nice to have a separate component for that as it is currently a
> > different implementation and also a different API/spec which is also
supported
> > across multiple browsers.. If the user/developer encounters an issue with
> > DeviceOrientation I think it would be easier to triage into it's own
component
> > and to address that way.
> 
> Jun has been working on a design doc for this merge here:
>
https://docs.google.com/document/d/1aJo41_Md9XhinVLAI1O2m2cnla9GIK-AkQ5vj1iXu...
> 
> I've updated the patch to put the DeviceOrientation implementation in the
> Blink>Sensor>DeviceOrientation component. Generic Sensors is still in the
> Blink>Sensor component because there aren't separate directories for the
various
> new sensor classes like Accelerometer, OrientationSensor, etc. I don't feel
that
> Blink>Sensor>GenericSensor will make sense to issue reporters. If we create
> components for these sensor types we can rearrange the source tree to make the
> mapping clear.
> 
> If you approve this I will go ahead and create the necessary new components.

OK, great, thanks! lgtm.

Thanks for the design doc pointer, would be interested to stay in the loop on
this ).

Regarding components structure I thought you might distinguish based on exposed
API (i.e. by spec) in which case generic sensors would make sense. But if things
are changing I guess the Blink>Sensor and Blink>Sensor>DeviceOrientation is
sufficient for now.

Also maybe change the title of the CL to something like: 'add COMPONENT and TEAM
to sensors API OWNERS files', which would better reflect the description. And by
means of nitpicking: probably good to update description to include
"Blink>Sensor / Blink>Sensor>DeviceOrientation components"

[Reilly Grant (use Gerrit), 2017-05-11 18:29:20]

Description was changed from

==========
Assign sensors API ownership to the device-dev@chromium.org TEAM.

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor component and device-dev@chromium.org team
mailing list.

BUG=None
==========

to

==========
Add COMPONENT and TEAM to sensors API OWNERS files

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor and Blink>Sensor>DeviceOrientation
components and device-dev@chromium.org team mailing list.

BUG=None
==========

[Reilly Grant (use Gerrit), 2017-05-11 18:34:44]

I've filed an issue to create the Blink>Sensor>DeviceOrientation component,

https://bugs.chromium.org/p/chromium/issues/detail?id=721476

[Reilly Grant (use Gerrit), 2017-05-11 18:34:49]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:35:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:05:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494527689376680,
"parent_rev": "c835005daf2e585752a4ae4b26d4393216054578", "commit_rev":
"8c4e6ca1e9ffd25f04505b1e451cf26e19c8101c"}

[commit-bot: I haz the power, 2017-05-11 20:05:22]

Description was changed from

==========
Add COMPONENT and TEAM to sensors API OWNERS files

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor and Blink>Sensor>DeviceOrientation
components and device-dev@chromium.org team mailing list.

BUG=None
==========

to

==========
Add COMPONENT and TEAM to sensors API OWNERS files

This change updates OWNERS files for device sensors-related directories
to point to the Blink>Sensor and Blink>Sensor>DeviceOrientation
components and device-dev@chromium.org team mailing list.

BUG=None

Review-Url: https://codereview.chromium.org/2774433002
Cr-Commit-Position: refs/heads/master@{#471050}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c4e6ca1e9ffd25f04505b1e451c...
==========

[commit-bot: I haz the power, 2017-05-11 20:05:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8c4e6ca1e9ffd25f04505b1e451c...