third_party/WebKit/Source/modules/device_orientation/OWNERS - Issue 2774433002: Add COMPONENT and TEAM to sensors API OWNERS files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/device_orientation/OWNERS

Issue 2774433002: Add COMPONENT and TEAM to sensors API OWNERS files (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 timvolodine@chromium.org	1 timvolodine@chromium.org

2	2

3 # COMPONENT: IO>DeviceOrientation	3 # COMPONENT: Blink>DeviceOrientation
	timvolodine 2017/03/29 16:39:13 The (IO\|Blink)>DeviceOrientation seems somewhat co The (IO\|Blink)>DeviceOrientation seems somewhat confusing (or too verbose), maybe just keep one? (i.e. IO>DeviceOrientation). Reilly Grant (use Gerrit) 2017/03/30 22:16:03 The reason for the IO/Blink separation is that the Show quoted text On 2017/03/29 16:39:13, timvolodine wrote: > The (IO\|Blink)>DeviceOrientation seems somewhat confusing (or too verbose), > maybe just keep one? (i.e. IO>DeviceOrientation). The reason for the IO/Blink separation is that the IO>Foo component captures bugs in the platform-specific code use for (in this case) accessing sensors which might be used by multiple components of Chrome, while the Blink>Foo component captures bugs in the implementation of the Foo web API. I established this pattern when maintaining //device/usb, the WebUSB API and the chrome.usb API because it was useful to have separate components for issues that effected communication with USB devices in general (since this code is consumed in a number of places) compared to issues in a particular developer-facing API. Since Generic Sensors is adding a number of new sensor types would you support renaming the existing IO>DeviceOrientation and Blink>DeviceOrientation components to IO>Sensors and Blink>Sensors? If you don't think that the separation described above makes sense for sensors then we can merge IO>Sensors into Blink>Sensors, which would cover all web platform sensor APIs.
	4 # TEAM: sensors-dev@chromium.org

OLD	NEW

« device/generic_sensor/OWNERS ('K') | « device/sensors/OWNERS ('k') | third_party/WebKit/Source/modules/sensor/OWNERS » ('j') | no next file with comments »