Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2774423006: Shrink the reference image dimension in OffscreenCanvas tests (Closed)

Created:
3 years, 8 months ago by xlai (Olivia)
Modified:
3 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, jam, jbroman, fmalita+watch_chromium.org, Rik, darin-cc_chromium.org, Justin Novosad, pdr+graphicswatchlist_chromium.org, blink-reviews, piman+watch_chromium.org, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Shrink the reference image dimension in OffscreenCanvas tests The android device has a screen resolution width of 1080 and devicePixelRatio of 2.625. As a result, the width of 600 in the existing gpu pixel tests is too big as width * devicePixelRatio > screen resolution. Therefore, I shrink the test rect to 400 in width. BUG=697582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2774423006 Cr-Commit-Position: refs/heads/master@{#460237} Committed: https://chromium.googlesource.com/chromium/src/+/772204b647bb8089ed2017718cc4afdeac1d80d1

Patch Set 1 #

Patch Set 2 : smaller star #

Patch Set 3 : clean up #

Patch Set 4 : update reference count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html View 1 3 chunks +8 lines, -8 lines 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html View 1 3 chunks +8 lines, -8 lines 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 2 3 1 chunk +20 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
xlai (Olivia)
3 years, 8 months ago (2017-03-28 21:29:24 UTC) #4
Zhenyao Mo
On 2017/03/28 21:29:24, xlai (Olivia) wrote: lgtm if bots are happy
3 years, 8 months ago (2017-03-28 21:48:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774423006/60001
3 years, 8 months ago (2017-03-28 23:18:20 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 23:35:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/772204b647bb8089ed2017718cc4...

Powered by Google App Engine
This is Rietveld 408576698