Refine the strings on the Incognito NTP and improve the descriptions

Refine the strings on the Incognito NTP and improve the descriptions

BUG=693525
Review-Url: https://codereview.chromium.org/2774293002
Cr-Commit-Position: refs/heads/master@{#460500}
Committed: https://chromium.googlesource.com/chromium/src/+/7ca3ccf74e804e13da4c622177f6fc6787019c1e

[msramek, 2017-03-27 10:46:13]

msramek@chromium.org changed reviewers:
+ srahim@chromium.org

[msramek, 2017-03-27 10:46:14]

Hi Shimi!

I saw that you moved your meeting with Chelsea, but can you please take a first
pass on the code review already? I think we're sufficiently settled on the
content now and I don't expect large changes... :)

Thanks,
Martin

[srahim, 2017-03-27 22:51:50]

Made some edits per legal review and to clarify message descriptions

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:150: Now you can browse privately, and
other people who use this device won’t see your activity. Downloads and
bookmarks will be kept.
Recommended: However, downloads and bookmarks will be saved. 

Add "however" to call this out because the paragraph begins by saying what won't
be seen.
We should avoid using the word "kept" and stick to familiar language like
"saved."

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
Change "highlighted" to "boldfaced or otherwise emphasized in the style
appropriate for your language.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
We need to delete "Your searches" per legal review so should also delete the
corresponding sentence in the desc

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:153: Chrome |won’t save| the following
information:#Your browsing history#Your searches#Cookies and site data
Delete the bullet "#Your searches" per legal review

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:155: <message
name="IDS_NEW_TAB_OTR_VISIBLE" desc="Bullet points listing entities that might
be able to see the user's Incognito activity. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. The bullet points elaborate on the fact that Incognito only
provides privacy with respect to other users on the same device. Websites you
visit still know that you visited them. Your employer and internet service
provider can still monitor network traffic, even if it comes from the Incognito
mode." formatter_data="android_java">
Change "highlighted" to "boldfaced or otherwise emphasized in the style
appropriate for your language"

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:156: Your activity |might still be
visible| to:#Websites you visit#Your employer#Your internet service provider
Chelsea agreed that we should add "your school" to more clearly convey the
meaning that any entity that manages your network may be able to see your
activity.

So the 2nd bullet would read: "Your employer or school"

[msramek, 2017-03-28 12:50:38]

I addressed your comments. PTAL!

In the meantime, let's finish the discussion about 'searches' on the email
thread :)

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:150: Now you can browse privately, and
other people who use this device won’t see your activity. Downloads and
bookmarks will be kept.
On 2017/03/27 22:51:50, srahim wrote:
> Recommended: However, downloads and bookmarks will be saved. 
> 
> Add "however" to call this out because the paragraph begins by saying what
won't
> be seen.
> We should avoid using the word "kept" and stick to familiar language like
> "saved." 

Done.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
On 2017/03/27 22:51:50, srahim wrote:
> Change "highlighted" to "boldfaced or otherwise emphasized in the style
> appropriate for your language.

Done.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
On 2017/03/27 22:51:50, srahim wrote:
> We need to delete "Your searches" per legal review so should also delete the
> corresponding sentence in the desc

Done, but I want to clarify what you mean.

The string will be post-processed in the code. I will replace the section
between || with <b></b> or <em></em> or something such. It is possible that for
different alphabets that will look differently, but in general, it will be
boldfaced.

Was your intention to ask translators to choose their own way of emphasis, e.g.
boldface vs. italics? I'm not sure if we want to do that. If a translator
misunderstands, they might accidentally replace || with invalid HTML tag, or
*hypothetically* insert malicious JavaScript code :)

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:153: Chrome |won’t save| the following
information:#Your browsing history#Your searches#Cookies and site data
On 2017/03/27 22:51:50, srahim wrote:
> Delete the bullet "#Your searches" per legal review

Done.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:155: <message
name="IDS_NEW_TAB_OTR_VISIBLE" desc="Bullet points listing entities that might
be able to see the user's Incognito activity. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. The bullet points elaborate on the fact that Incognito only
provides privacy with respect to other users on the same device. Websites you
visit still know that you visited them. Your employer and internet service
provider can still monitor network traffic, even if it comes from the Incognito
mode." formatter_data="android_java">
On 2017/03/27 22:51:49, srahim wrote:
> Change "highlighted" to "boldfaced or otherwise emphasized in the style
> appropriate for your language"

Done. (But please see my clarification question as above)

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:156: Your activity |might still be
visible| to:#Websites you visit#Your employer#Your internet service provider
On 2017/03/27 22:51:49, srahim wrote:
> Chelsea agreed that we should add "your school" to more clearly convey the
> meaning that any entity that manages your network may be able to see your
> activity.
> 
> So the 2nd bullet would read: "Your employer or school" 

Done (here and in the description).

[srahim, 2017-03-28 23:03:44]

LGTM with clarification on the boldface/emphasis formatting. Thanks for ensuring
the edits didn't add confusion.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
On 2017/03/28 12:50:37, msramek wrote:
> On 2017/03/27 22:51:50, srahim wrote:
> > We need to delete "Your searches" per legal review so should also delete the
> > corresponding sentence in the desc
> 
> Done, but I want to clarify what you mean.
> 
> The string will be post-processed in the code. I will replace the section
> between || with <b></b> or <em></em> or something such. It is possible that
for
> different alphabets that will look differently, but in general, it will be
> boldfaced.
> 
> Was your intention to ask translators to choose their own way of emphasis,
e.g.
> boldface vs. italics? I'm not sure if we want to do that. If a translator
> misunderstands, they might accidentally replace || with invalid HTML tag, or
> *hypothetically* insert malicious JavaScript code :)

No, the reason I suggested a change was because I was afraid they would
interpret "highlighted" to mean highlighting format, e.g. yellow. We could just
say "the text between the pair of || characters will be formatted
programmatically to emphasize those words." To avoid the misunderstanding of
replacing || with invalid HTML.

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:155: <message
name="IDS_NEW_TAB_OTR_VISIBLE" desc="Bullet points listing entities that might
be able to see the user's Incognito activity. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. The bullet points elaborate on the fact that Incognito only
provides privacy with respect to other users on the same device. Websites you
visit still know that you visited them. Your employer and internet service
provider can still monitor network traffic, even if it comes from the Incognito
mode." formatter_data="android_java">
On 2017/03/28 12:50:37, msramek wrote:
> On 2017/03/27 22:51:49, srahim wrote:
> > Change "highlighted" to "boldfaced or otherwise emphasized in the style
> > appropriate for your language"
> 
> Done. (But please see my clarification question as above)

I was afraid they would
interpret "highlighted" to mean highlighting format, e.g. yellow. We could just
say "the text between the pair of || characters will be formatted
programmatically to emphasize those words." To avoid the misunderstanding of
replacing || with invalid HTML.

[msramek, 2017-03-29 09:52:49]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-03-29 09:56:39]

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:152: <message
name="IDS_NEW_TAB_OTR_NOT_SAVED_BULLET_POINTS" desc="Bullet points listing data
that are not saved in the Incognito mode. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. 'Browsing history' means a history of visited websites. 'Searches'
means searches done in the address bar. 'Cookies and site data' refers to data
saved by websites on the user's device (e.g. sign-in state, preferences, etc.)."
formatter_data="android_java">
On 2017/03/28 23:03:43, srahim wrote:
> On 2017/03/28 12:50:37, msramek wrote:
> > On 2017/03/27 22:51:50, srahim wrote:
> > > We need to delete "Your searches" per legal review so should also delete
the
> > > corresponding sentence in the desc
> > 
> > Done, but I want to clarify what you mean.
> > 
> > The string will be post-processed in the code. I will replace the section
> > between || with <b></b> or <em></em> or something such. It is possible that
> for
> > different alphabets that will look differently, but in general, it will be
> > boldfaced.
> > 
> > Was your intention to ask translators to choose their own way of emphasis,
> e.g.
> > boldface vs. italics? I'm not sure if we want to do that. If a translator
> > misunderstands, they might accidentally replace || with invalid HTML tag, or
> > *hypothetically* insert malicious JavaScript code :)
> 
> No, the reason I suggested a change was because I was afraid they would
> interpret "highlighted" to mean highlighting format, e.g. yellow. We could
just
> say "the text between the pair of || characters will be formatted
> programmatically to emphasize those words." To avoid the misunderstanding of
> replacing || with invalid HTML.

Done. Makes sense, thanks!

https://codereview.chromium.org/2774293002/diff/1/components/new_or_sad_tab_s...
components/new_or_sad_tab_strings.grdp:155: <message
name="IDS_NEW_TAB_OTR_VISIBLE" desc="Bullet points listing entities that might
be able to see the user's Incognito activity. The '#' character in this text
represents a bullet point. Please keep it unchanged and do not add additional
spaces around it. The text between the pair of '|' characters will be
highlighted. The bullet points elaborate on the fact that Incognito only
provides privacy with respect to other users on the same device. Websites you
visit still know that you visited them. Your employer and internet service
provider can still monitor network traffic, even if it comes from the Incognito
mode." formatter_data="android_java">
On 2017/03/28 23:03:44, srahim wrote:
> On 2017/03/28 12:50:37, msramek wrote:
> > On 2017/03/27 22:51:49, srahim wrote:
> > > Change "highlighted" to "boldfaced or otherwise emphasized in the style
> > > appropriate for your language"
> > 
> > Done. (But please see my clarification question as above)
> 
> I was afraid they would
> interpret "highlighted" to mean highlighting format, e.g. yellow. We could
just
> say "the text between the pair of || characters will be formatted
> programmatically to emphasize those words." To avoid the misunderstanding of
> replacing || with invalid HTML.

Done, as above.

[msramek, 2017-03-29 10:00:08]

msramek@chromium.org changed reviewers:
+ sdefresne@chromium.org

[msramek, 2017-03-29 10:00:09]

Thanks, Shimi!

+Sylvain, please have a look! This is a followup to the CL with Incognito NTP
strings that I sent you recently. This time, I had it reviewed by Shimi from the
UX team to finalize the strings and improve the descriptions, so I only need a
rubberstamp. Thanks!

[commit-bot: I haz the power, 2017-03-29 10:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:01:16]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-29 11:39:06]

https://codereview.chromium.org/2774293002/diff/60001/components/new_or_sad_t...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/60001/components/new_or_sad_t...
components/new_or_sad_tab_strings.grdp:153: Chrome |won’t save| the following
information:#Your browsing history#Cookies and site data
I don't see where those two messages are used. However, it looks like we usually
use something like the following to add formatting instruction in a translatable
string:

    <ph name="BEGIN_BOLD">&lt;strong&gt;</ph>Caution:<ph
name="END_BOLD">&lt;/strong&gt;</ph>  These files are temporary and may be
automatically deleted to free up disk space.  <ph name="BEGIN_LINK">&lt;a
href="javascript://"&gt;</ph>Learn More<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>

(from chrome/app/chromeos_strings.grdp)

So instead of adding instructions for translator, could you instead do the
following:

Chrome <ph name="BEGIN_EMPHASIS">&lt;em&gt;<ex>&lt;em&gt;</ex></ph>won't save<ph
name="END_EMPHASIS">&lt;em&gt;<ex>&lt;/em&gt;</ex></ph> the following
information:<ph name="BEGIN_LIST">&lt;em&gt;<ex>&lt;ul&gt;</ex></ph><ph
name="LIST_ITEM_1">&lt;em&gt;<ex>&lt;li&gt;</ex></ph>Your browsing history<ph
name="LIST_ITEM_2">&lt;em&gt;<ex>&lt;li&gt;</ex></ph>Cookies and site data<ph
name="END_LIST">&lt;em&gt;<ex>&lt;/ul&gt;</ex></ph>

or, if you do not / cannot use html, just put | and # in the value for the ph
items:

Chrome <ph name="BEGIN_EMPHASIS">|<ex>&lt;em&gt;</ex></ph>won't save<ph
name="END_EMPHASIS">|<ex>&lt;/em&gt;</ex></ph> the following information:<ph
name="BEGIN_LIST"><ex>&lt;ul&gt;</ex></ph><ph
name="LIST_ITEM_1">#<ex>&lt;li&gt;</ex></ph>Your browsing history<ph
name="LIST_ITEM_2">#<ex>&lt;li&gt;</ex></ph>Cookies and site data<ph
name="END_LIST"><ex>&lt;/ul&gt;</ex></ph>

[msramek, 2017-03-29 15:45:57]

Thanks, Sylvain! I reformatted the strings. PTAL!

https://codereview.chromium.org/2774293002/diff/60001/components/new_or_sad_t...
File components/new_or_sad_tab_strings.grdp (right):

https://codereview.chromium.org/2774293002/diff/60001/components/new_or_sad_t...
components/new_or_sad_tab_strings.grdp:153: Chrome |won’t save| the following
information:#Your browsing history#Cookies and site data
On 2017/03/29 11:39:06, sdefresne wrote:
> I don't see where those two messages are used. However, it looks like we
usually
> use something like the following to add formatting instruction in a
translatable
> string:
> 
>     <ph name="BEGIN_BOLD">&lt;strong&gt;</ph>Caution:<ph
> name="END_BOLD">&lt;/strong&gt;</ph>  These files are temporary and may be
> automatically deleted to free up disk space.  <ph name="BEGIN_LINK">&lt;a
> href="javascript://"&gt;</ph>Learn More<ph
> name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
> 
> (from chrome/app/chromeos_strings.grdp)
> 
> So instead of adding instructions for translator, could you instead do the
> following:
> 
> Chrome <ph name="BEGIN_EMPHASIS">&lt;em&gt;<ex>&lt;em&gt;</ex></ph>won't
save<ph
> name="END_EMPHASIS">&lt;em&gt;<ex>&lt;/em&gt;</ex></ph> the following
> information:<ph name="BEGIN_LIST">&lt;em&gt;<ex>&lt;ul&gt;</ex></ph><ph
> name="LIST_ITEM_1">&lt;em&gt;<ex>&lt;li&gt;</ex></ph>Your browsing history<ph
> name="LIST_ITEM_2">&lt;em&gt;<ex>&lt;li&gt;</ex></ph>Cookies and site data<ph
> name="END_LIST">&lt;em&gt;<ex>&lt;/ul&gt;</ex></ph>
> 
> or, if you do not / cannot use html, just put | and # in the value for the ph
> items:
> 
> Chrome <ph name="BEGIN_EMPHASIS">|<ex>&lt;em&gt;</ex></ph>won't save<ph
> name="END_EMPHASIS">|<ex>&lt;/em&gt;</ex></ph> the following information:<ph
> name="BEGIN_LIST"><ex>&lt;ul&gt;</ex></ph><ph
> name="LIST_ITEM_1">#<ex>&lt;li&gt;</ex></ph>Your browsing history<ph
> name="LIST_ITEM_2">#<ex>&lt;li&gt;</ex></ph>Cookies and site data<ph
> name="END_LIST"><ex>&lt;/ul&gt;</ex></ph>
> 

Yeah, the approach with the special characters is what was used in some places
in the old WebUI. I agree that this is better.

I took inspiration from IDS_ENABLE_DEBUGGING_HELP, which means that:
- I left out the <ex> parts which don't really make sense, since we do not
substitute those placeholders
- I formatted the string in a nicer way, since HTML doesn't mind whitespaces

I verified in the translation console that this format was understood well by
the translators :) I verified on the new tab page (but I haven't that CL ready
yet) that the HTML look correct.

As a last minute request from the l10n team, I added translateable=false, as
these strings are supposed to go to the transcreation process and not the usual
translation.

[msramek, 2017-03-29 15:46:26]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:58:09]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-29 18:09:28]

lgtm

Could I ask what is the "transcreation process"?

[msramek, 2017-03-29 19:36:55]

Thanks!

Normally, translators only get the strings and descriptions, which can lead to
imprecise and inconsistent translations if the context isn't clear.

For transcreation, they get the whole set of strings and a lot of background
information, and may adjust things that don't make sense when exactly
translated.

I also only learned recently that we have that :) The Incognito NTP is an ideal
candidate, since the whole set of strings appears next to each and must make
sense together, and the risk of misinterpretation is high.

[msramek, 2017-03-29 19:37:44]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-03-29 19:37:45]

The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org
Link to the patchset: https://codereview.chromium.org/2774293002/#ps80001
(title: "Reformatted the placeholders.")

[commit-bot: I haz the power, 2017-03-29 19:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 19:48:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490816264747080,
"parent_rev": "d0fca10eff7508cf86c231af8dfee0da3609b677", "commit_rev":
"7ca3ccf74e804e13da4c622177f6fc6787019c1e"}

[commit-bot: I haz the power, 2017-03-29 19:48:59]

Description was changed from

==========
Refine the strings on the Incognito NTP and improve the descriptions

BUG=693525
==========

to

==========
Refine the strings on the Incognito NTP and improve the descriptions

BUG=693525

Review-Url: https://codereview.chromium.org/2774293002
Cr-Commit-Position: refs/heads/master@{#460500}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ca3ccf74e804e13da4c622177f6...
==========

[commit-bot: I haz the power, 2017-03-29 19:49:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7ca3ccf74e804e13da4c622177f6...