Specify AllowCaching = false for dynamically-generated contents

Specify AllowCaching = false for dynamically-generated contents

WebUI still have some resources that may be modified when user settings
are updated, or some other background tasks, e.g. updating Extensions,
run. Just in case, such URLDataSource inheritances should not allow
caching so to reflect modified contents immediately.

BUG=669776
Review-Url: https://codereview.chromium.org/2774263002
Cr-Commit-Position: refs/heads/master@{#460672}
Committed: https://chromium.googlesource.com/chromium/src/+/bb7ab1896220b565660dc68f6d6304c1bcea002e

[Takashi Toyoshima, 2017-03-27 09:36:27]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 09:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 11:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 11:32:02]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2017-03-28 08:33:53]

Description was changed from

==========
Specify AllowCaching = false for dynamically-generated contents

WebUI still have some resources that may be modified when user settings
are updated, or some other background tasks, e.g. updating Extensions,
run. Just in case, such URLDataSource inheritances should not allow
caching so to reflect modified contents immediately.

BUG=669776
==========

to

==========
Specify AllowCaching = false for dynamically-generated contents

WebUI still have some resources that may be modified when user settings
are updated, or some other background tasks, e.g. updating Extensions,
run. Just in case, such URLDataSource inheritances should not allow
caching so to reflect modified contents immediately.

BUG=669776
==========

[Takashi Toyoshima, 2017-03-28 08:33:53]

toyoshim@chromium.org changed reviewers:
+ dbeam@chromium.org

[Takashi Toyoshima, 2017-03-28 08:36:02]

Hi, I would make this change to flip the cache flag to safer side against
remaining inheritances. WDYT?

[Dan Beam, 2017-03-29 00:54:02]

how did you choose these?

[Takashi Toyoshima, 2017-03-29 06:55:05]

Others were already fixed, or confirmed to be fine.
https://docs.google.com/a/chromium.org/spreadsheets/d/1_Jgd5EIsDBJ65dItDpKoR8...

[Dan Beam, 2017-03-30 00:46:38]

lgtm

[Takashi Toyoshima, 2017-03-30 02:38:59]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-30 02:39:06]

The CQ bit was unchecked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-30 02:42:04]

toyoshim@chromium.org changed reviewers:
+ sky@chromium.org

[Takashi Toyoshima, 2017-03-30 02:43:46]

+sky for approval

[sky, 2017-03-30 03:30:44]

On 2017/03/30 02:43:46, Takashi Toyoshima wrote:
> +sky for approval

I think Dan is owner of all this, and I'm not really familiar with the change.
Are you sure you need me?

[Takashi Toyoshima, 2017-03-30 03:56:37]

Oh, really. Chrome Extension, Chromite Butler that I use show the first four
files in red, that's why I added you to the reviewer list. Let me try just
pushing this to CQ without your approval.

[Takashi Toyoshima, 2017-03-30 03:56:45]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-30 04:01:52]

OK, Dan is in ui/webui/OWNERS. It seems Chromite Butler can not handle "file:"
line in OWNER files correctly.
Sorry for bothering you.

[commit-bot: I haz the power, 2017-03-30 05:28:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490846205865370,
"parent_rev": "2de5b0418f39c8ae1068e0fedabe6dd2aee312ca", "commit_rev":
"bb7ab1896220b565660dc68f6d6304c1bcea002e"}

[commit-bot: I haz the power, 2017-03-30 05:29:24]

Description was changed from

==========
Specify AllowCaching = false for dynamically-generated contents

WebUI still have some resources that may be modified when user settings
are updated, or some other background tasks, e.g. updating Extensions,
run. Just in case, such URLDataSource inheritances should not allow
caching so to reflect modified contents immediately.

BUG=669776
==========

to

==========
Specify AllowCaching = false for dynamically-generated contents

WebUI still have some resources that may be modified when user settings
are updated, or some other background tasks, e.g. updating Extensions,
run. Just in case, such URLDataSource inheritances should not allow
caching so to reflect modified contents immediately.

BUG=669776

Review-Url: https://codereview.chromium.org/2774263002
Cr-Commit-Position: refs/heads/master@{#460672}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb7ab1896220b565660dc68f6d63...
==========

[commit-bot: I haz the power, 2017-03-30 05:29:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb7ab1896220b565660dc68f6d63...