Specify AllowCaching = false for dynamically-generated contents

chrome/browser/ui/webui/options/options_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 182 matching lines @@
  public:
   // The constructor takes over ownership of |localized_strings|.
   explicit OptionsUIHTMLSource(base::DictionaryValue* localized_strings);
 
   // content::URLDataSource implementation.
   std::string GetSource() const override;
   void StartDataRequest(
       const std::string& path,
       const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
       const content::URLDataSource::GotDataCallback& callback) override;
+  bool AllowCaching() const override;
   std::string GetMimeType(const std::string&) const override;
   bool ShouldDenyXFrameOptions() const override;
 
  private:
   ~OptionsUIHTMLSource() override;
   void CreateDataSourceMap();
 
   // Localized strings collection.
   std::unique_ptr<base::DictionaryValue> localized_strings_;
   std::map<std::string, int> path_to_idr_map_;
@@ skipping 50 matching lines @@
     std::string replaced = ui::ReplaceTemplateExpressions(
         base::StringPiece(response_bytes->front_as<char>(),
                           response_bytes->size()),
         replacements_);
     response_bytes = base::RefCountedString::TakeString(&replaced);
   }
 
   callback.Run(response_bytes.get());
 }
 
+bool OptionsUIHTMLSource::AllowCaching() const {
+  // Should not be cached to reflect dynamically-generated contents that depends
+  // on the current locale.
+  return false;
+}
+
 std::string OptionsUIHTMLSource::GetMimeType(const std::string& path) const {
   if (base::EndsWith(path, ".js", base::CompareCase::INSENSITIVE_ASCII))
     return "application/javascript";
 
   return "text/html";
 }
 
 bool OptionsUIHTMLSource::ShouldDenyXFrameOptions() const {
   return false;
 }
@@ skipping 346 matching lines @@
   // Add only if handler's service is enabled.
   if (handler->IsEnabled()) {
     // Add handler to the list and also pass the ownership.
     web_ui()->AddMessageHandler(std::move(handler));
     handler_raw->GetLocalizedValues(localized_strings);
     handlers_.push_back(handler_raw);
   }
 }
 
 }  // namespace options