Creating PaymentOptionsProvider interface

Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow
forthcoming profile filtering and deduplication options (and anything
else which depends on these values) to be written cross-platform, and
reduces the bleeding of Mojo into views logic that doesn't really need
to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this
  interface. It removes the options() accessor, which is no longer
  necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions
  class which corresponds to, and can be trivially modified to
  implement, this interface.
- Android: A small utility class implementing this interface is
  forthcoming. The needed data is present as accessible members of
  PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be
updated to pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117
Review-Url: https://codereview.chromium.org/2774233005
Cr-Commit-Position: refs/heads/master@{#460639}
Committed: https://chromium.googlesource.com/chromium/src/+/5f0912b87c3814ad7a4891f428e8a5b84d477e69

[tmartino, 2017-03-28 19:58:21]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-03-28 20:07:47]

Description was changed from

==========
Creating PaymentOptionsProvider

BUG=
==========

to

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow forthcoming
profile filtering and deduplication options (and anything else which depends on
these values) to be written cross-platform, and reduces the bleeding of Mojo
into views logic that doesn't really need to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this interface. It
removes the options() accessor, which is no longer necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions class
which corresponds to, and can be trivially modified to implement, this
interface.
- Android: A small utility class implementing this interface is forthcoming. The
needed data is present as accessible members of PaymentRequestImpl.

BUG=706117
==========

[tmartino, 2017-03-28 20:10:28]

Description was changed from

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow forthcoming
profile filtering and deduplication options (and anything else which depends on
these values) to be written cross-platform, and reduces the bleeding of Mojo
into views logic that doesn't really need to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this interface. It
removes the options() accessor, which is no longer necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions class
which corresponds to, and can be trivially modified to implement, this
interface.
- Android: A small utility class implementing this interface is forthcoming. The
needed data is present as accessible members of PaymentRequestImpl.

BUG=706117
==========

to

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow forthcoming
profile filtering and deduplication options (and anything else which depends on
these values) to be written cross-platform, and reduces the bleeding of Mojo
into views logic that doesn't really need to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this interface. It
removes the options() accessor, which is no longer necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions class
which corresponds to, and can be trivially modified to implement, this
interface.
- Android: A small utility class implementing this interface is forthcoming. The
needed data is present as accessible members of PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be updated to
pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117
==========

[commit-bot: I haz the power, 2017-03-28 20:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 20:14:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-03-28 20:39:53]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 20:40:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:15:11]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[tmartino, 2017-03-29 18:29:49]

tmartino@chromium.org changed reviewers:
+ sebsg@chromium.org

[tmartino, 2017-03-29 18:29:49]

+sebsg, who volunteered to do a first pass based on offline conversations.

[sebsg, 2017-03-29 19:35:23]

Sweet! LGTM!

[tmartino, 2017-03-29 19:37:00]

tmartino@chromium.org changed reviewers:
+ rouslan@chromium.org

[tmartino, 2017-03-29 19:37:01]

Thanks Seb! +rouslan for OWNERS

[please use gerrit instead, 2017-03-29 21:45:16]

LGTM % comments.

Please format the CL description as follows:

<At most 64 characters of title.>

<Paragraphs of at most 72 characters each.>
<Paragraphs of at most 72 characters each.>
<Paragraphs of at most 72 characters each.>

<BUG=XYZ>

The reason for this formatting is to look better in "git log" on people's narrow
terminals. Although most terminals are 80 character wide, the possible reverts
and relands will prepend each line with "> ", which will make the lines wider.

The even shorter requirement for the title is to accommodate the git revision
hash and possible [Merge M-59] type tags.

The website does not accommodate reflowing your comments easily, but you can use
your favorite editor instead by running "git cl format" from command line. Thank
you!

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_views_util.h:13: #include
"components/payments/core/payment_options_provider.h"
It should be possible to forward-declare PaymentOptionsProvider instead.

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_views_util.h:84:
PaymentOptionsProvider* options);
const-ref because you don't plan to modify the |options|.

https://codereview.chromium.org/2774233005/diff/20001/components/payments/cor...
File components/payments/core/payment_options_provider.h (right):

https://codereview.chromium.org/2774233005/diff/20001/components/payments/cor...
components/payments/core/payment_options_provider.h:17: // An abstract class
which provides immutable values, specified by the merchant
s/abstract class/interface/g

Because all methods (except destructor) are pure virtual.

[tmartino, 2017-03-29 21:50:27]

Description was changed from

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow forthcoming
profile filtering and deduplication options (and anything else which depends on
these values) to be written cross-platform, and reduces the bleeding of Mojo
into views logic that doesn't really need to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this interface. It
removes the options() accessor, which is no longer necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions class
which corresponds to, and can be trivially modified to implement, this
interface.
- Android: A small utility class implementing this interface is forthcoming. The
needed data is present as accessible members of PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be updated to
pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117
==========

to

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow
forthcoming profile filtering and deduplication options (and anything
else which depends on these values) to be written cross-platform, and
reduces the bleeding of Mojo into views logic that doesn't really need
to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this
  interface. It removes the options() accessor, which is no longer
  necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions
  class which corresponds to, and can be trivially modified to
  implement, this interface.
- Android: A small utility class implementing this interface is
  forthcoming. The needed data is present as accessible members of
  PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be
updated to pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117
==========

[tmartino, 2017-03-29 22:42:08]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:43:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:05:07]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-03-30 03:14:23]

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_views_util.h:13: #include
"components/payments/core/payment_options_provider.h"
On 2017/03/29 at 21:45:16, ಠ_ಠ wrote:
> It should be possible to forward-declare PaymentOptionsProvider instead.

Done

https://codereview.chromium.org/2774233005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_views_util.h:84:
PaymentOptionsProvider* options);
On 2017/03/29 at 21:45:16, ಠ_ಠ wrote:
> const-ref because you don't plan to modify the |options|.

Done.

https://codereview.chromium.org/2774233005/diff/20001/components/payments/cor...
File components/payments/core/payment_options_provider.h (right):

https://codereview.chromium.org/2774233005/diff/20001/components/payments/cor...
components/payments/core/payment_options_provider.h:17: // An abstract class
which provides immutable values, specified by the merchant
On 2017/03/29 at 21:45:16, ಠ_ಠ wrote:
> s/abstract class/interface/g
> 
> Because all methods (except destructor) are pure virtual.

Done.

[tmartino, 2017-03-30 03:14:25]

The CQ bit was checked by tmartino@chromium.org

[tmartino, 2017-03-30 03:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2774233005/#ps40001
(title: "rouslan comments")

[commit-bot: I haz the power, 2017-03-30 03:15:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:20:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490843665162700,
"parent_rev": "e83ab9c6c27deb3e96dee4a33a6518c206724d16", "commit_rev":
"5f0912b87c3814ad7a4891f428e8a5b84d477e69"}

[commit-bot: I haz the power, 2017-03-30 03:21:56]

Description was changed from

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow
forthcoming profile filtering and deduplication options (and anything
else which depends on these values) to be written cross-platform, and
reduces the bleeding of Mojo into views logic that doesn't really need
to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this
  interface. It removes the options() accessor, which is no longer
  necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions
  class which corresponds to, and can be trivially modified to
  implement, this interface.
- Android: A small utility class implementing this interface is
  forthcoming. The needed data is present as accessible members of
  PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be
updated to pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117
==========

to

==========
Creating PaymentOptionsProvider, a Mojo-less interface for providing
PaymentOptions, suitable for use in components/core. This will allow
forthcoming profile filtering and deduplication options (and anything
else which depends on these values) to be written cross-platform, and
reduces the bleeding of Mojo into views logic that doesn't really need
to know about it.

Usage details:
- Desktop: This CL changes PaymentRequestSpec to implement this
  interface. It removes the options() accessor, which is no longer
  necessary.
- iOS: the iOS version of payment_request.h already has a PaymentOptions
  class which corresponds to, and can be trivially modified to
  implement, this interface.
- Android: A small utility class implementing this interface is
  forthcoming. The needed data is present as accessible members of
  PaymentRequestImpl.

See also crrev.com/2775553004 for further context. That CL will be
updated to pass PaymentOptionsProvider instead of PaymentRequestSpec.

BUG=706117

Review-Url: https://codereview.chromium.org/2774233005
Cr-Commit-Position: refs/heads/master@{#460639}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f0912b87c3814ad7a4891f428e8...
==========

[commit-bot: I haz the power, 2017-03-30 03:21:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5f0912b87c3814ad7a4891f428e8...