Creating PaymentOptionsProvider interface

chrome/browser/ui/views/payments/payment_request_views_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_
 
 #include <memory>
 #include <string>
 
 #include "base/strings/string16.h"
 #include "components/payments/content/payment_request.mojom.h"
+#include "components/payments/core/payment_options_provider.h"

[please use gerrit instead, 2017/03/29 21:45:16]

It should be possible to forward-declare PaymentOptionsProvider instead.

[tmartino, 2017/03/30 03:14:22]

Done

 
 namespace autofill {
 class AutofillProfile;
 }
 
 namespace views {
 class Border;
 class ButtonListener;
 class ImageView;
 class Label;
@@ skipping 50 matching lines @@
     const std::string& locale,
     const autofill::AutofillProfile& profile);
 
 // Extracts and formats descriptive text from the given |profile| to represent
 // the contact info in the context specified by |type|. Includes/excludes name,
 // email, and phone fields according to the respective boolean fields.
 std::unique_ptr<views::View> GetContactInfoLabel(
     AddressStyleType type,
     const std::string& locale,
     const autofill::AutofillProfile& profile,
-    bool show_payer_name,
-    bool show_payer_phone,
-    bool show_payer_email);
+    PaymentOptionsProvider* options);

[please use gerrit instead, 2017/03/29 21:45:16]

const-ref because you don't plan to modify the |options|.

[tmartino, 2017/03/30 03:14:22]

Done.

 
 // Creates a views::Border object that can paint the gray horizontal ruler used
 // as a separator between items in the Payment Request dialog.
 std::unique_ptr<views::Border> CreatePaymentRequestRowBorder();
 
 // Creates a label with a bold font.
 std::unique_ptr<views::Label> CreateBoldLabel(const base::string16& text);
 
 base::string16 GetShippingAddressSectionString(
-    payments::mojom::PaymentShippingType shipping_type);
+    PaymentShippingType shipping_type);
 base::string16 GetShippingOptionSectionString(
-    payments::mojom::PaymentShippingType shipping_type);
+    PaymentShippingType shipping_type);
 
 std::unique_ptr<views::View> CreateShippingOptionLabel(
     payments::mojom::PaymentShippingOption* shipping_option,
     const base::string16& formatted_amount);
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_VIEWS_UTIL_H_