Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2774193002: [Offline pages] Ensuring native init when OBT run though JobScheduler (Closed)

Created:
3 years, 9 months ago by fgorski
Modified:
3 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Ensuring native init when OBT run though JobScheduler When OfflineBackgroundTask is scheduled and run through JobScheduler we are currently experiencing an assert on debug builds (and this should lead to NPE on release builds). This patch fixes the issue and is intended to be handling it in the short term, until BackgroundTaskScheduler provides a proper support for that scenario. BUG=704990 R=nyquist@chromium.org Review-Url: https://codereview.chromium.org/2773843003 Cr-Commit-Position: refs/heads/master@{#459525} (cherry picked from commit b382956014fb295322ee15b14f72712b93b174aa) Review-Url: https://codereview.chromium.org/2774193002 . Cr-Commit-Position: refs/branch-heads/3029@{#420} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/88fe890f426fc5bc77b7b766f78290b73924b542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTask.java View 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
3 years, 9 months ago (2017-03-26 03:51:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88fe890f426fc5bc77b7b766f78290b73924b542.

Powered by Google App Engine
This is Rietveld 408576698