Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2773843003: [Offline pages] Ensuring native init when OBT run though JobScheduler (Closed)

Created:
3 years, 9 months ago by fgorski
Modified:
3 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Ensuring native init when OBT run though JobScheduler When OfflineBackgroundTask is scheduled and run through JobScheduler we are currently experiencing an assert on debug builds (and this should lead to NPE on release builds). This patch fixes the issue and is intended to be handling it in the short term, until BackgroundTaskScheduler provides a proper support for that scenario. BUG=704990 R=nyquist@chromium.org Review-Url: https://codereview.chromium.org/2773843003 Cr-Commit-Position: refs/heads/master@{#459525} Committed: https://chromium.googlesource.com/chromium/src/+/b382956014fb295322ee15b14f72712b93b174aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTask.java View 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
fgorski
PTAL
3 years, 9 months ago (2017-03-24 18:32:33 UTC) #2
nyquist
lgtm!
3 years, 9 months ago (2017-03-24 18:40:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773843003/1
3 years, 9 months ago (2017-03-24 19:34:46 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 19:43:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b382956014fb295322ee15b14f72...

Powered by Google App Engine
This is Rietveld 408576698