Mark remaining IDS_FLAGS* in generated_resources.grd as translateable=false

Mark remaining IDS_FLAGS* in generated_resources.grd as translateable=false

When https://codereview.chromium.org/2757193002/ marked all IDS_FLAGS* messages
in generated_resources.grd as non-translateable, it used a simple
pattern-matching instead of proper XML parsing. Therefore it missed messages
which contained line breaks in the <message> tags.

This CL fixes the handful of messages which slipped through in
https://codereview.chromium.org/2757193002/.

The presubmit script added in https://codereview.chromium.org/2757193002/ also
has the same issue: it expects that the translateable attribute and the message
name (IDS_FLAGS_*) appear on the same line. To fix it would be non-trivial,
because it should operate on the diff (as opposed to the whole file), which is
hard to parse as XML. With https://crbug.com/703134#c4 being actively worked
on, the presubmit script will not be used any longer, though, so this CL does
not attempt to fix that.

BUG=587272
Review-Url: https://codereview.chromium.org/2774153002
Cr-Commit-Position: refs/heads/master@{#459777}
Committed: https://chromium.googlesource.com/chromium/src/+/ce65031046bcb48b22d02a2eb3bc9e88c73e6561

[vabr (Chromium), 2017-03-25 22:36:17]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 22:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-25 22:37:41]

vabr@chromium.org changed reviewers:
+ agrieve@chromium.org

[vabr (Chromium), 2017-03-25 22:37:42]

Hi agrieve@,

Could you please review a quick follow-up to my previous translateable=false CL?
Cleaning this up makes it easier for me to have proper checks in the scripts
generating the migration from resource strings to const char[] constants.

Cheers,
Vaclav

[commit-bot: I haz the power, 2017-03-25 23:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 23:14:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2017-03-27 13:48:55]

On 2017/03/25 22:37:42, vabr (Chromium) wrote:
> Hi agrieve@,
> 
> Could you please review a quick follow-up to my previous translateable=false
CL?
> Cleaning this up makes it easier for me to have proper checks in the scripts
> generating the migration from resource strings to const char[] constants.
> 
> Cheers,
> Vaclav

lgtm

[vabr (Chromium), 2017-03-27 13:51:05]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-27 13:51:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 14:35:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490622665012650, "parent_rev":
"9626beccc3f01f82a06a05e563c40b7494ccd1ac", "commit_rev":
"ce65031046bcb48b22d02a2eb3bc9e88c73e6561"}

[commit-bot: I haz the power, 2017-03-27 14:36:21]

Description was changed from

==========
Mark remaining IDS_FLAGS* in generated_resources.grd as translateable=false

When https://codereview.chromium.org/2757193002/ marked all IDS_FLAGS* messages
in generated_resources.grd as non-translateable, it used a simple
pattern-matching instead of proper XML parsing. Therefore it missed messages
which contained line breaks in the <message> tags.

This CL fixes the handful of messages which slipped through in
https://codereview.chromium.org/2757193002/.

The presubmit script added in https://codereview.chromium.org/2757193002/ also
has the same issue: it expects that the translateable attribute and the message
name (IDS_FLAGS_*) appear on the same line. To fix it would be non-trivial,
because it should operate on the diff (as opposed to the whole file), which is
hard to parse as XML. With https://crbug.com/703134#c4 being actively worked
on, the presubmit script will not be used any longer, though, so this CL does
not attempt to fix that.

BUG=587272
==========

to

==========
Mark remaining IDS_FLAGS* in generated_resources.grd as translateable=false

When https://codereview.chromium.org/2757193002/ marked all IDS_FLAGS* messages
in generated_resources.grd as non-translateable, it used a simple
pattern-matching instead of proper XML parsing. Therefore it missed messages
which contained line breaks in the <message> tags.

This CL fixes the handful of messages which slipped through in
https://codereview.chromium.org/2757193002/.

The presubmit script added in https://codereview.chromium.org/2757193002/ also
has the same issue: it expects that the translateable attribute and the message
name (IDS_FLAGS_*) appear on the same line. To fix it would be non-trivial,
because it should operate on the diff (as opposed to the whole file), which is
hard to parse as XML. With https://crbug.com/703134#c4 being actively worked
on, the presubmit script will not be used any longer, though, so this CL does
not attempt to fix that.

BUG=587272

Review-Url: https://codereview.chromium.org/2774153002
Cr-Commit-Position: refs/heads/master@{#459777}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce65031046bcb48b22d02a2eb3bc...
==========

[commit-bot: I haz the power, 2017-03-27 14:36:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce65031046bcb48b22d02a2eb3bc...