Make flags resources naming consistent

Make flags resources naming consistent

About:flags strings usually start with IDS_FLAGS_, up to a handful of
exceptions. Making the naming consistent will make the migration of the
resource strings to C++ const char* constants easier.

This CL changes the naming to fit the convention. It also does these things:
* Fixes a typo in the XML file generated_resources.grd, where an <if> tag was
  spread over too many elements.
* Moves IDS_FLAGS_DEBUG_SHORTCUTS_DESCRIPTION out of branded strings to just
  generated ones: it is not important to mentione the product name in telling
  the developer/tester that a particular flag activates the debug shortcuts.
  (Also, once migrated to const char* strings, it won't be possible any more.)
* Adds translateable=false to the renamed messages as needed (and enforced by
  the presubmit script).
* Reformats touched lines with clang-format, as enforced by the presubmit script.
* Splits IDS_OPTIONS_ENABLE_SPELLCHECK, which is used both for non-MacOSX settings and for an Android-specific flag, separating the flag use under the name IDS_FLAGS_ENABLE_ANDROID_SPELLCHECKER_NAME.

BUG=703134, 587272
Review-Url: https://codereview.chromium.org/2773323002
Cr-Commit-Position: refs/heads/master@{#459819}
Committed: https://chromium.googlesource.com/chromium/src/+/777c16b153d01257a6c0b01b50bb4fc11943331f

[vabr (Chromium), 2017-03-26 02:11:12]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 02:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 02:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 02:22:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2017-03-26 02:35:53]

Description was changed from

==========
Make flags resources naming consistent

About:flags strings usually start with IDS_FLAGS_, up to a handful of
exceptions. Making the naming consistent will make the migration of the
resource strings to C++ const char* constants easier.

This CL changes the naming to fit the convention. It also does these things:
* Fixes a typo in the XML file generated_resources.grd, where an <if> tag was
  spread over too many elements.
* Moves IDS_FLAGS_DEBUG_SHORTCUTS_DESCRIPTION out of branded strings to just
  generated ones: it is not important to mentione the product name in telling
  the developer/tester that a particular flag activates the debug shortcuts.
  (Also, once migrated to const char* strings, it won't be possible any more.)
* Adds translateable=false to the renamed messages as needed (and enforced by
  the presubmit script).
* Reformats touched lines with clang-format, as enforced by the presubmit
script.

BUG=703134, 587272
==========

to

==========
Make flags resources naming consistent

About:flags strings usually start with IDS_FLAGS_, up to a handful of
exceptions. Making the naming consistent will make the migration of the
resource strings to C++ const char* constants easier.

This CL changes the naming to fit the convention. It also does these things:
* Fixes a typo in the XML file generated_resources.grd, where an <if> tag was
  spread over too many elements.
* Moves IDS_FLAGS_DEBUG_SHORTCUTS_DESCRIPTION out of branded strings to just
  generated ones: it is not important to mentione the product name in telling
  the developer/tester that a particular flag activates the debug shortcuts.
  (Also, once migrated to const char* strings, it won't be possible any more.)
* Adds translateable=false to the renamed messages as needed (and enforced by
  the presubmit script).
* Reformats touched lines with clang-format, as enforced by the presubmit
script.
* Splits IDS_OPTIONS_ENABLE_SPELLCHECK, which is used both for non-MacOSX
settings and for an Android-specific flag, separating the flag use under the
name IDS_FLAGS_ENABLE_ANDROID_SPELLCHECKER_NAME.

BUG=703134, 587272
==========

[vabr (Chromium), 2017-03-26 02:39:42]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 02:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 03:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 03:00:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vabr (Chromium), 2017-03-26 03:51:15]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 03:51:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 04:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 04:49:02]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-26 05:37:42]

vabr@chromium.org changed reviewers:
+ agrieve@chromium.org

[vabr (Chromium), 2017-03-26 05:37:43]

Hi agrieve@,

This is the second part of the preparation for the main CL. Would you be able to
review it as well?

Thanks!
Vaclav

[agrieve, 2017-03-27 13:51:17]

On 2017/03/26 05:37:43, vabr (Chromium) wrote:
> Hi agrieve@,
> 
> This is the second part of the preparation for the main CL. Would you be able
to
> review it as well?
> 
> Thanks!
> Vaclav

lgtm

[vabr (Chromium), 2017-03-27 16:44:19]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:45:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 17:39:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490633059791170,
"parent_rev": "b51be7a1564e95d921b63eef020b8436fdfc6c10", "commit_rev":
"777c16b153d01257a6c0b01b50bb4fc11943331f"}

[commit-bot: I haz the power, 2017-03-27 17:40:16]

Description was changed from

==========
Make flags resources naming consistent

About:flags strings usually start with IDS_FLAGS_, up to a handful of
exceptions. Making the naming consistent will make the migration of the
resource strings to C++ const char* constants easier.

This CL changes the naming to fit the convention. It also does these things:
* Fixes a typo in the XML file generated_resources.grd, where an <if> tag was
  spread over too many elements.
* Moves IDS_FLAGS_DEBUG_SHORTCUTS_DESCRIPTION out of branded strings to just
  generated ones: it is not important to mentione the product name in telling
  the developer/tester that a particular flag activates the debug shortcuts.
  (Also, once migrated to const char* strings, it won't be possible any more.)
* Adds translateable=false to the renamed messages as needed (and enforced by
  the presubmit script).
* Reformats touched lines with clang-format, as enforced by the presubmit
script.
* Splits IDS_OPTIONS_ENABLE_SPELLCHECK, which is used both for non-MacOSX
settings and for an Android-specific flag, separating the flag use under the
name IDS_FLAGS_ENABLE_ANDROID_SPELLCHECKER_NAME.

BUG=703134, 587272
==========

to

==========
Make flags resources naming consistent

About:flags strings usually start with IDS_FLAGS_, up to a handful of
exceptions. Making the naming consistent will make the migration of the
resource strings to C++ const char* constants easier.

This CL changes the naming to fit the convention. It also does these things:
* Fixes a typo in the XML file generated_resources.grd, where an <if> tag was
  spread over too many elements.
* Moves IDS_FLAGS_DEBUG_SHORTCUTS_DESCRIPTION out of branded strings to just
  generated ones: it is not important to mentione the product name in telling
  the developer/tester that a particular flag activates the debug shortcuts.
  (Also, once migrated to const char* strings, it won't be possible any more.)
* Adds translateable=false to the renamed messages as needed (and enforced by
  the presubmit script).
* Reformats touched lines with clang-format, as enforced by the presubmit
script.
* Splits IDS_OPTIONS_ENABLE_SPELLCHECK, which is used both for non-MacOSX
settings and for an Android-specific flag, separating the flag use under the
name IDS_FLAGS_ENABLE_ANDROID_SPELLCHECKER_NAME.

BUG=703134, 587272

Review-Url: https://codereview.chromium.org/2773323002
Cr-Commit-Position: refs/heads/master@{#459819}
Committed:
https://chromium.googlesource.com/chromium/src/+/777c16b153d01257a6c0b01b50bb...
==========

[commit-bot: I haz the power, 2017-03-27 17:40:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/777c16b153d01257a6c0b01b50bb...