In memory_details, change HasConnection() to IsReady()

HasConnection -> IsReady

The problem was that calling getProcId on a null process handle is an error.
IsReady checks both the connection as well as for a valid handle. It is
possible that we manage to connect to a child process before we actually
get its handle back from the process launcher.

BUG=704647
Review-Url: https://codereview.chromium.org/2773853002
Cr-Commit-Position: refs/heads/master@{#459526}
Committed: https://chromium.googlesource.com/chromium/src/+/96fb832e2f8abff293fb34fd320e2222707f585b

[ncarter (slow), 2017-03-23 22:20:28]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[ncarter (slow), 2017-03-23 22:20:46]

Description was changed from

==========
HasConnection -> IsReady

The problem was that calling getProcId on a null process handle is an error.
IsReady checks both the connection as well as for a valid handle. It is
possible that we manage to connect to a child process before we actually
get its handle back from the process launcher.

BUG=704647
==========

to

==========
HasConnection -> IsReady

The problem was that calling getProcId on a null process handle is an error.
IsReady checks both the connection as well as for a valid handle. It is
possible that we manage to connect to a child process before we actually
get its handle back from the process launcher.

BUG=704647
==========

[ncarter (slow), 2017-03-23 22:21:17]

nick@chromium.org changed reviewers:
+ creis@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-03-23 22:24:56]

Thanks!  LGTM.

[commit-bot: I haz the power, 2017-03-23 23:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:15:26]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2017-03-24 18:03:56]

nick@chromium.org changed reviewers:
+ thakis@chromium.org

[ncarter (slow), 2017-03-24 18:03:57]

thakis@chromium.org: Please approve

[Nico, 2017-03-24 18:11:08]

i approve

Is it possible to test this though?

[ncarter (slow), 2017-03-24 18:26:07]

On 2017/03/24 18:11:08, Nico wrote:
> i approve
> 
> Is it possible to test this though?

It's possible, but I'm not sure it's worth the effort.

The "child process connected but we haven't obtained a handle from process
launcher yet" race is hard to trigger reliably. And a unittest (using
MockRenderProcessHost) wouldn't really be testing the behavior that matters,
namely that RenderProcessHostImpl::IsReady does a null handle check here.

[Nico, 2017-03-24 18:27:48]

a'ight, lgtm

[ncarter (slow), 2017-03-24 19:36:53]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2017-03-24 19:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:44:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490384213742080, "parent_rev":
"b382956014fb295322ee15b14f72712b93b174aa", "commit_rev":
"96fb832e2f8abff293fb34fd320e2222707f585b"}

[commit-bot: I haz the power, 2017-03-24 19:45:24]

Description was changed from

==========
HasConnection -> IsReady

The problem was that calling getProcId on a null process handle is an error.
IsReady checks both the connection as well as for a valid handle. It is
possible that we manage to connect to a child process before we actually
get its handle back from the process launcher.

BUG=704647
==========

to

==========
HasConnection -> IsReady

The problem was that calling getProcId on a null process handle is an error.
IsReady checks both the connection as well as for a valid handle. It is
possible that we manage to connect to a child process before we actually
get its handle back from the process launcher.

BUG=704647

Review-Url: https://codereview.chromium.org/2773853002
Cr-Commit-Position: refs/heads/master@{#459526}
Committed:
https://chromium.googlesource.com/chromium/src/+/96fb832e2f8abff293fb34fd320e...
==========

[commit-bot: I haz the power, 2017-03-24 19:45:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96fb832e2f8abff293fb34fd320e...