Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4862)

Unified Diff: chrome/browser/memory_details.cc

Issue 2773853002: In memory_details, change HasConnection() to IsReady() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory_details.cc
diff --git a/chrome/browser/memory_details.cc b/chrome/browser/memory_details.cc
index 3aa27449ba53d98afc7a97b91468631b3604e071..0153e1af96a4dc403469f9a65c98f5b130df0874 100644
--- a/chrome/browser/memory_details.cc
+++ b/chrome/browser/memory_details.cc
@@ -228,8 +228,9 @@ void MemoryDetails::CollectChildInfoOnUIThread() {
std::unique_ptr<content::RenderWidgetHostIterator> widget_it(
RenderWidgetHost::GetRenderWidgetHosts());
while (content::RenderWidgetHost* widget = widget_it->GetNextHost()) {
- // Ignore processes that don't have a connection, such as crashed tabs.
- if (!widget->GetProcess()->HasConnection())
+ // Ignore processes that don't have a connection, such as crashed tabs,
+ // or processes that are still launching.
+ if (!widget->GetProcess()->IsReady())
continue;
base::ProcessId pid = base::GetProcId(widget->GetProcess()->GetHandle());
widgets_by_pid[pid].push_back(widget);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698