Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2773573003: Don't GONE the unsuspended video only players (Closed)

Created:
3 years, 9 months ago by whywhat
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Don't GONE the unsuspended video only players Video only players are reported to RendererWebMediaPlayerDelegate as GONE even if they're playing. This CL would make sure we only report suspended players as GONE. This affects the logic in MediaWebContentsDelegate that creates the power blocker for videos. BUG=703105 TEST=manual Review-Url: https://codereview.chromium.org/2767253002 Cr-Commit-Position: refs/heads/master@{#458995} (cherry picked from commit 5f34b644166c2dc02f7f937f69ce0fd08e89e626) Review-Url: https://codereview.chromium.org/2773573003 . Cr-Commit-Position: refs/branch-heads/2987@{#868} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/83cf01eb0a7b96415d46bd7b9dcd91d2cda43c23

Patch Set 1 #

Patch Set 2 : Fixed the unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M media/blink/webmediaplayer_impl.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
whywhat
Fixed the unittest
3 years, 9 months ago (2017-03-23 03:33:02 UTC) #1
whywhat
3 years, 9 months ago (2017-03-23 03:35:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
83cf01eb0a7b96415d46bd7b9dcd91d2cda43c23.

Powered by Google App Engine
This is Rietveld 408576698