Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2773573003: Don't GONE the unsuspended video only players (Closed)
Patch Set: Fixed the unittest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index d7065b5d65ba21cd7692b56c5a2a391f699ff10f..6ef0dacec1abe39a5d06d3f38b66d8882d5259e4 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -443,6 +443,18 @@ TEST_F(WebMediaPlayerImplTest, ComputePlayState_Playing) {
EXPECT_TRUE(state.is_memory_reporting_enabled);
}
+TEST_F(WebMediaPlayerImplTest, ComputePlayState_PlayingVideoOnly) {
+ InitializeWebMediaPlayerImpl();
+ SetMetadata(false, true);
+ SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+ SetPaused(false);
+ WebMediaPlayerImpl::PlayState state = ComputePlayState();
+ EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
+ EXPECT_FALSE(state.is_idle);
+ EXPECT_FALSE(state.is_suspended);
+ EXPECT_TRUE(state.is_memory_reporting_enabled);
+}
+
TEST_F(WebMediaPlayerImplTest, ComputePlayState_Underflow) {
InitializeWebMediaPlayerImpl();
SetMetadata(true, true);
@@ -492,12 +504,18 @@ TEST_F(WebMediaPlayerImplTest, ComputePlayState_FrameHiddenSuspendNoResume) {
SetMetadata(true, true);
SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
SetPaused(false);
-
WebMediaPlayerImpl::PlayState state = ComputePlayState_FrameHidden();
- EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
- EXPECT_TRUE(state.is_idle);
+ EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
+ EXPECT_FALSE(state.is_idle);
EXPECT_FALSE(state.is_suspended);
EXPECT_TRUE(state.is_memory_reporting_enabled);
+
+ SetPaused(true);
+ state = ComputePlayState_FrameHidden();
+ EXPECT_EQ(WebMediaPlayerImpl::DelegateState::GONE, state.delegate_state);
+ EXPECT_TRUE(state.is_idle);
+ EXPECT_TRUE(state.is_suspended);
+ EXPECT_FALSE(state.is_memory_reporting_enabled);
}
TEST_F(WebMediaPlayerImplTest, ComputePlayState_FrameHiddenSuspendWithResume) {
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698