Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2773503002: [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 This CL: - Changes GooglePlayWebApkInstallDelegate#installAsync() to return a WebApkInstallResult in the callback. - Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk(). BUG=692249 Review-Url: https://codereview.chromium.org/2728053002 Cr-Commit-Position: refs/heads/master@{#457300} (cherry picked from commit 19d929ae378491116d7683764baa6365d1ddd50d) Review-Url: https://codereview.chromium.org/2773503002 . Cr-Commit-Position: refs/branch-heads/3029@{#369} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5fe87344efe197796525404ffa44f5a0049a77e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/GooglePlayWebApkInstallDelegate.java View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
pkotwicz
3 years, 9 months ago (2017-03-22 20:29:46 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5fe87344efe197796525404ffa44f5a0049a77e6.

Powered by Google App Engine
This is Rietveld 408576698