[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3

[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3

This CL:
- Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
  WebApkInstallResult in the callback.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().

BUG=696132
Review-Url: https://codereview.chromium.org/2728053002
Cr-Commit-Position: refs/heads/master@{#457300}
Committed: https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa6365d1ddd50d

[pkotwicz, 2017-03-03 03:49:57]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-03-03 03:49:58]

Dominick, can you please take a look?

[dominickn, 2017-03-06 02:30:47]

On 2017/03/03 03:49:58, pkotwicz wrote:
> Dominick, can you please take a look?

This looks good, but we'll resolve 1/3 first and see if there are any changes
needed here.

[pkotwicz, 2017-03-15 14:50:25]

Dominick, can you please take another look?

[dominickn, 2017-03-15 22:47:04]

Won't landing this break the internal build until that side of the patch lands?
Perhaps you should add a new installAsync method that takes the
Callback<Integer> argument and call that in this CL, make the internal side do
the right thing, then delete the extraneous method? That's how we usually do
these 3 sided patches.

[pkotwicz, 2017-03-15 23:43:23]

Because GooglePlayWebApkInstallDelegate is an interface landing this CL will
break the internal build regardless. If I added a new installAsync() method the
internal build would break because the method is not implemented

[pkotwicz, 2017-03-15 23:43:24]

Because GooglePlayWebApkInstallDelegate is an interface landing this CL will
break the internal build regardless. If I added a new installAsync() method the
internal build would break because the method is not implemented

[pkotwicz, 2017-03-15 23:43:28]

Because GooglePlayWebApkInstallDelegate is an interface landing this CL will
break the internal build regardless. If I added a new installAsync() method the
internal build would break because the method is not implemented

[dominickn, 2017-03-15 23:59:35]

Ah true, I forgot that in Java you have to override everything in an interface.
lgtm then.

[pkotwicz, 2017-03-16 00:18:02]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:28:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489623482710590,
"parent_rev": "0f3941c30bdb81dcb934d6a12d84859eedebff0e", "commit_rev":
"19d929ae378491116d7683764baa6365d1ddd50d"}

[commit-bot: I haz the power, 2017-03-16 01:29:35]

Description was changed from

==========
[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part
2/3

This CL:
- Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
  WebApkInstallResult in the callback.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().

BUG=696132
==========

to

==========
[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part
2/3

This CL:
- Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
  WebApkInstallResult in the callback.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().

BUG=696132

Review-Url: https://codereview.chromium.org/2728053002
Cr-Commit-Position: refs/heads/master@{#457300}
Committed:
https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa...
==========

[commit-bot: I haz the power, 2017-03-16 01:29:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa...

[cblume, 2017-03-16 06:04:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2757563002/ by cblume@chromium.org.

The reason for reverting is: This is causing build failures on
clang-clankium-tot-builder
See:
https://crbug.com/702086
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla....