Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2773173002: [DevTools] Enable full-size screenshots (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Enable full-size screenshots With new fromSurface parameter, this should work on all OSes. BUG=638281 Review-Url: https://codereview.chromium.org/2773173002 Cr-Commit-Position: refs/heads/master@{#460589} Committed: https://chromium.googlesource.com/chromium/src/+/0d7958ef3d03590b0063fe6d284763132e718b3f

Patch Set 1 #

Patch Set 2 : features.txt ftw #

Patch Set 3 : small screenshots refactor, almost works #

Patch Set 4 : works, but not sharp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -160 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 2 3 2 chunks +37 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 2 3 1 chunk +76 lines, -124 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/help/features.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Geometry.js View 1 2 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
3 years, 9 months ago (2017-03-24 19:20:03 UTC) #2
pfeldman
Could you migrate regular screenshots to this code path and add it into what's new?
3 years, 9 months ago (2017-03-24 19:23:23 UTC) #3
dgozman
PTAL, works now!
3 years, 8 months ago (2017-03-28 22:23:44 UTC) #4
pfeldman
lgtm
3 years, 8 months ago (2017-03-29 21:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2773173002/60001
3 years, 8 months ago (2017-03-29 22:09:53 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:12:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0d7958ef3d03590b0063fe6d2847...

Powered by Google App Engine
This is Rietveld 408576698