Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

Issue 2773173002: [DevTools] Enable full-size screenshots (Closed)
Patch Set: works, but not sharp Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js
index cc2ea881cea2ed0c004c03fa78b2cddf657723f9..fa4e168ffe7e9aa74f5ad964d964b465639adbb4 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js
@@ -48,7 +48,7 @@ SDK.ScreenCaptureModel = class extends SDK.SDKModel {
captureScreenshot(format, quality) {
var fulfill;
var promise = new Promise(callback => fulfill = callback);
- this._agent.captureScreenshot(format, quality, false, (error, content) => {
+ this._agent.captureScreenshot(format, quality, true, (error, content) => {
if (error)
console.error(error);
fulfill(error ? null : content);
@@ -57,13 +57,19 @@ SDK.ScreenCaptureModel = class extends SDK.SDKModel {
}
/**
- * @return {!Promise<?{width: number, height: number}>}
+ * @return {!Promise<?{viewportX: number, viewportY: number, viewportScale: number, contentWidth: number, contentHeight: number}>}
*/
- fetchContentSize() {
+ fetchLayoutMetrics() {
var fulfill;
var promise = new Promise(callback => fulfill = callback);
this._agent.getLayoutMetrics((error, layoutViewport, visualViewport, contentSize) => {
- fulfill(error ? null : {width: contentSize.width, height: contentSize.height});
+ fulfill(error ? null : {
+ viewportX: visualViewport.pageX,
+ viewportY: visualViewport.pageY,
+ viewportScale: visualViewport.scale,
+ contentWidth: contentSize.width,
+ contentHeight: contentSize.height
+ });
});
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698