Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2773113002: Fix an issue when media controls never hide after certain tap sequence (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue when media controls never hide after certain tap sequence This CL fixes an issue on media controls where after certain tap sequences, the controls never hide because the control panel is hovered (which should not happen). The fix is to ignore the hovering state if the panel is tapped. BUG=701746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-24 14:03:16 UTC) #2
mlamouri (slow - plz ping)
sgtm but can you add a test for this?
3 years, 8 months ago (2017-03-30 13:29:15 UTC) #7
Zhiqiang Zhang (Slow)
On 2017/03/30 at 13:29:15, mlamouri wrote: > sgtm but can you add a test for ...
3 years, 8 months ago (2017-03-30 16:23:30 UTC) #8
mlamouri (slow - plz ping)
3 years, 8 months ago (2017-03-30 20:47:12 UTC) #9
As discussed offline, I think we show the controls quite aggressively and hiding
them more shouldn't be a problem :)

Powered by Google App Engine
This is Rietveld 408576698