Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2773113002: Fix an issue when media controls never hide after certain tap sequence (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
index 6fcf2642e672bbb9fa145f243b43bcf7045fa993..98da5af534486485d3e50826ce4ed22abbb4ba57 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
@@ -713,7 +713,10 @@ void MediaControls::defaultEventHandler(Event* event) {
// the event handled to avoid buttons below the tap to be activated.
event->setDefaultHandled();
}
- if (shouldHideMediaControls(IgnoreWaitForTimer)) {
+ // TODO(zqzhang): temporary workaround to fix an issue on Android where
+ // the controls panel is always hovered after certain tap sequence.
+ if (shouldHideMediaControls(IgnoreWaitForTimer | IgnoreControlsHover |
+ IgnoreVideoHover)) {
m_keepShowingUntilTimerFires = true;
startHideMediaControlsTimer();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698