Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2773103002: cc: Unify all sources of color space for YUVVideoDrawQuad (Closed)

Created:
3 years, 9 months ago by Chandan
Modified:
3 years, 3 months ago
Reviewers:
hubbe, ccameron
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Unify all sources of color space for YUVVideoDrawQuad Currently there are three sources of the color space: the resource, quad->color_space, and quad->video_color_space. This CL removes color_space, video_color_space from YUVVideoDrawQuad and ensures resource color space is used while drawing the quads. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -202 lines) Patch
M cc/ipc/cc_param_traits.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M cc/ipc/cc_param_traits_macros.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/ipc/cc_param_traits_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M cc/ipc/quads.mojom View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/ipc/quads_struct_traits.h View 2 chunks +0 lines, -15 lines 0 comments Download
M cc/ipc/quads_struct_traits.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +4 lines, -19 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 7 chunks +8 lines, -24 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 6 chunks +9 lines, -35 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.h View 5 chunks +0 lines, -15 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 5 chunks +23 lines, -1 line 0 comments Download
M cc/test/render_pass_test_utils.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Chandan
On 2017/03/24 13:23:38, Chandan wrote: > mailto:c.padhi@samsung.com changed reviewers: > + mailto:ccameron@chromium.org PTAL. Thank you.
3 years, 9 months ago (2017-03-24 13:24:14 UTC) #4
ccameron
On 2017/03/24 13:24:14, Chandan wrote: > On 2017/03/24 13:23:38, Chandan wrote: > > mailto:c.padhi@samsung.com changed ...
3 years, 9 months ago (2017-03-27 21:06:51 UTC) #6
Chandan
3 years, 8 months ago (2017-03-30 20:05:23 UTC) #7
On 2017/03/27 21:06:51, ccameron wrote:
> On 2017/03/24 13:24:14, Chandan wrote:
> > On 2017/03/24 13:23:38, Chandan wrote:
> > > mailto:c.padhi@samsung.com changed reviewers:
> > > + mailto:ccameron@chromium.org
> > 
> > PTAL. Thank you.
> 
> I agree that we definitely want to do this at some point, but I'd prefer to
> leave all pluming in place for the moment while we work towards enabling color
> correct rendering.

Sure.

Powered by Google App Engine
This is Rietveld 408576698