Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 2773103002: cc: Unify all sources of color space for YUVVideoDrawQuad (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/renderer_pixeltest.cc
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
index ca3bb6d247ec22eb3ceb9bc854ce2ceab8f46f1b..489f5d93221c5d5cabe30c27e5289a00be814b9a 100644
--- a/cc/output/renderer_pixeltest.cc
+++ b/cc/output/renderer_pixeltest.cc
@@ -212,15 +212,6 @@ void CreateTestYUVVideoDrawQuad_FromVideoFrame(
const gfx::Rect& visible_rect,
ResourceProvider* resource_provider) {
const bool with_alpha = (video_frame->format() == media::PIXEL_FORMAT_YV12A);
- YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::REC_601;
- int video_frame_color_space;
- if (video_frame->metadata()->GetInteger(
- media::VideoFrameMetadata::COLOR_SPACE, &video_frame_color_space) &&
- video_frame_color_space == media::COLOR_SPACE_JPEG) {
- color_space = YUVVideoDrawQuad::JPEG;
- }
-
- gfx::ColorSpace video_color_space = video_frame->ColorSpace();
const gfx::Rect opaque_rect(0, 0, 0, 0);
@@ -294,8 +285,7 @@ void CreateTestYUVVideoDrawQuad_FromVideoFrame(
yuv_quad->SetNew(shared_state, rect, opaque_rect, visible_rect,
ya_tex_coord_rect, uv_tex_coord_rect, ya_tex_size,
uv_tex_size, y_resource, u_resource, v_resource, a_resource,
- color_space, video_color_space, 0.0f, 1.0f,
- bits_per_channel);
+ 0.0f, 1.0f, bits_per_channel);
}
void CreateTestY16TextureDrawQuad_FromVideoFrame(
@@ -526,7 +516,6 @@ void CreateTestYUVVideoDrawQuad_Solid(
}
void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state,
- media::ColorSpace video_frame_color_space,
const gfx::ColorSpace& video_color_space,
const gfx::RectF& tex_coord_rect,
uint8_t y,
@@ -536,11 +525,6 @@ void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state,
const gfx::Rect& rect,
const gfx::Rect& visible_rect,
ResourceProvider* resource_provider) {
- YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::REC_601;
- if (video_frame_color_space == media::COLOR_SPACE_JPEG) {
- color_space = YUVVideoDrawQuad::JPEG;
- }
-
const gfx::Rect opaque_rect(0, 0, 0, 0);
const gfx::Size ya_tex_size = rect.size();
const gfx::Size uv_tex_size = media::VideoFrame::PlaneSize(
@@ -548,10 +532,10 @@ void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state,
ResourceId y_resource = resource_provider->CreateResource(
rect.size(), ResourceProvider::TEXTURE_HINT_DEFAULT,
- resource_provider->YuvResourceFormat(8), gfx::ColorSpace());
+ resource_provider->YuvResourceFormat(8), video_color_space);
ResourceId u_resource = resource_provider->CreateResource(
uv_tex_size, ResourceProvider::TEXTURE_HINT_DEFAULT, RGBA_8888,
- gfx::ColorSpace());
+ video_color_space);
ResourceId v_resource = u_resource;
ResourceId a_resource = 0;
@@ -578,7 +562,7 @@ void CreateTestYUVVideoDrawQuad_NV12(const SharedQuadState* shared_state,
yuv_quad->SetNew(shared_state, rect, opaque_rect, visible_rect,
ya_tex_coord_rect, uv_tex_coord_rect, ya_tex_size,
uv_tex_size, y_resource, u_resource, v_resource, a_resource,
- color_space, video_color_space, 0.0f, 1.0f, 8);
+ 0.0f, 1.0f, 8);
}
void CreateTestY16TextureDrawQuad_TwoColor(
@@ -1383,10 +1367,10 @@ TEST_F(VideoGLRendererPixelTest, SimpleNV12JRect) {
CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
// YUV of (149,43,21) should be green (0,255,0) in RGB.
- CreateTestYUVVideoDrawQuad_NV12(
- shared_state, media::COLOR_SPACE_JPEG, gfx::ColorSpace::CreateJpeg(),
- gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43, 21, pass.get(), rect, rect,
- resource_provider_.get());
+ CreateTestYUVVideoDrawQuad_NV12(shared_state, gfx::ColorSpace::CreateJpeg(),
+ gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43,
+ 21, pass.get(), rect, rect,
+ resource_provider_.get());
RenderPassList pass_list;
pass_list.push_back(std::move(pass));
« no previous file with comments | « cc/output/overlay_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698