Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: cc/quads/draw_quad_unittest.cc

Issue 2773103002: cc: Unify all sources of color space for YUVVideoDrawQuad (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/renderer_pixeltest.cc ('k') | cc/quads/yuv_video_draw_quad.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/draw_quad_unittest.cc
diff --git a/cc/quads/draw_quad_unittest.cc b/cc/quads/draw_quad_unittest.cc
index fce24b153d70eb57e788c003f933bc7c1da30db3..706474db9414a470dcc5d0f64bbff92d162b0966 100644
--- a/cc/quads/draw_quad_unittest.cc
+++ b/cc/quads/draw_quad_unittest.cc
@@ -370,15 +370,6 @@ void CompareDrawQuad(DrawQuad* quad,
} \
SETUP_AND_COPY_QUAD_NEW(Type, quad_new);
-#define CREATE_QUAD_13_ALL(Type, a, b, c, d, e, f, g, h, i, j, k, l, m) \
- Type* quad_all = render_pass->CreateAndAppendDrawQuad<Type>(); \
- { \
- QUAD_DATA quad_all->SetAll(shared_state, quad_rect, quad_opaque_rect, \
- quad_visible_rect, needs_blending, a, b, c, d, \
- e, f, g, h, i, j, k, l, m); \
- } \
- SETUP_AND_COPY_QUAD_ALL(Type, quad_all);
-
#define CREATE_QUAD_14_NEW(Type, a, b, c, d, e, f, g, h, i, j, k, l, m, n) \
Type* quad_new = render_pass->CreateAndAppendDrawQuad<Type>(); \
{ \
@@ -387,14 +378,6 @@ void CompareDrawQuad(DrawQuad* quad,
} \
SETUP_AND_COPY_QUAD_NEW(Type, quad_new);
-#define CREATE_QUAD_15_NEW(Type, a, b, c, d, e, f, g, h, i, j, k, l, m, n, o) \
- Type* quad_new = render_pass->CreateAndAppendDrawQuad<Type>(); \
- { \
- QUAD_DATA quad_new->SetNew(shared_state, quad_rect, a, b, c, d, e, f, g, \
- h, i, j, k, l, m, n, o); \
- } \
- SETUP_AND_COPY_QUAD_NEW(Type, quad_new);
-
#define CREATE_QUAD_ALL_RP(Type, a, b, c, d, e, f, g, copy_a) \
Type* quad_all = render_pass->CreateAndAppendDrawQuad<Type>(); \
{ \
@@ -636,16 +619,13 @@ TEST(DrawQuadTest, CopyYUVVideoDrawQuad) {
float resource_offset = 0.5f;
float resource_multiplier = 2.001f;
uint32_t bits_per_channel = 5;
- YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::JPEG;
- gfx::ColorSpace video_color_space = gfx::ColorSpace::CreateJpeg();
CREATE_SHARED_STATE();
- CREATE_QUAD_15_NEW(YUVVideoDrawQuad, opaque_rect, visible_rect,
+ CREATE_QUAD_13_NEW(YUVVideoDrawQuad, opaque_rect, visible_rect,
ya_tex_coord_rect, uv_tex_coord_rect, ya_tex_size,
uv_tex_size, y_plane_resource_id, u_plane_resource_id,
- v_plane_resource_id, a_plane_resource_id, color_space,
- video_color_space, resource_offset, resource_multiplier,
- bits_per_channel);
+ v_plane_resource_id, a_plane_resource_id, resource_offset,
+ resource_multiplier, bits_per_channel);
EXPECT_EQ(DrawQuad::YUV_VIDEO_CONTENT, copy_quad->material);
EXPECT_EQ(opaque_rect, copy_quad->opaque_rect);
EXPECT_EQ(visible_rect, copy_quad->visible_rect);
@@ -657,16 +637,15 @@ TEST(DrawQuadTest, CopyYUVVideoDrawQuad) {
EXPECT_EQ(u_plane_resource_id, copy_quad->u_plane_resource_id());
EXPECT_EQ(v_plane_resource_id, copy_quad->v_plane_resource_id());
EXPECT_EQ(a_plane_resource_id, copy_quad->a_plane_resource_id());
- EXPECT_EQ(color_space, copy_quad->color_space);
EXPECT_EQ(resource_offset, copy_quad->resource_offset);
EXPECT_EQ(resource_multiplier, copy_quad->resource_multiplier);
EXPECT_EQ(bits_per_channel, copy_quad->bits_per_channel);
- CREATE_QUAD_13_ALL(YUVVideoDrawQuad, ya_tex_coord_rect, uv_tex_coord_rect,
+ CREATE_QUAD_11_ALL(YUVVideoDrawQuad, ya_tex_coord_rect, uv_tex_coord_rect,
ya_tex_size, uv_tex_size, y_plane_resource_id,
u_plane_resource_id, v_plane_resource_id,
- a_plane_resource_id, color_space, video_color_space,
- resource_offset, resource_multiplier, bits_per_channel);
+ a_plane_resource_id, resource_offset, resource_multiplier,
+ bits_per_channel);
EXPECT_EQ(DrawQuad::YUV_VIDEO_CONTENT, copy_quad->material);
EXPECT_EQ(ya_tex_coord_rect, copy_quad->ya_tex_coord_rect);
EXPECT_EQ(uv_tex_coord_rect, copy_quad->uv_tex_coord_rect);
@@ -676,7 +655,6 @@ TEST(DrawQuadTest, CopyYUVVideoDrawQuad) {
EXPECT_EQ(u_plane_resource_id, copy_quad->u_plane_resource_id());
EXPECT_EQ(v_plane_resource_id, copy_quad->v_plane_resource_id());
EXPECT_EQ(a_plane_resource_id, copy_quad->a_plane_resource_id());
- EXPECT_EQ(color_space, copy_quad->color_space);
EXPECT_EQ(resource_offset, copy_quad->resource_offset);
EXPECT_EQ(resource_multiplier, copy_quad->resource_multiplier);
EXPECT_EQ(bits_per_channel, copy_quad->bits_per_channel);
@@ -871,21 +849,17 @@ TEST_F(DrawQuadIteratorTest, YUVVideoDrawQuad) {
ResourceId u_plane_resource_id = 532;
ResourceId v_plane_resource_id = 4;
ResourceId a_plane_resource_id = 63;
- YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::JPEG;
- gfx::ColorSpace video_color_space = gfx::ColorSpace::CreateJpeg();
-
CREATE_SHARED_STATE();
- CREATE_QUAD_15_NEW(YUVVideoDrawQuad, opaque_rect, visible_rect,
+
+ CREATE_QUAD_13_NEW(YUVVideoDrawQuad, opaque_rect, visible_rect,
ya_tex_coord_rect, uv_tex_coord_rect, ya_tex_size,
uv_tex_size, y_plane_resource_id, u_plane_resource_id,
- v_plane_resource_id, a_plane_resource_id, color_space,
- video_color_space, 0.0, 1.0, 5);
+ v_plane_resource_id, a_plane_resource_id, 0.0, 1.0, 5);
EXPECT_EQ(DrawQuad::YUV_VIDEO_CONTENT, copy_quad->material);
EXPECT_EQ(y_plane_resource_id, quad_new->y_plane_resource_id());
EXPECT_EQ(u_plane_resource_id, quad_new->u_plane_resource_id());
EXPECT_EQ(v_plane_resource_id, quad_new->v_plane_resource_id());
EXPECT_EQ(a_plane_resource_id, quad_new->a_plane_resource_id());
- EXPECT_EQ(color_space, quad_new->color_space);
EXPECT_EQ(4, IterateAndCount(quad_new));
EXPECT_EQ(y_plane_resource_id + 1, quad_new->y_plane_resource_id());
EXPECT_EQ(u_plane_resource_id + 1, quad_new->u_plane_resource_id());
« no previous file with comments | « cc/output/renderer_pixeltest.cc ('k') | cc/quads/yuv_video_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698