Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: third_party/WebKit/public/web/WebWidgetClient.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)
Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebViewClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebWidgetClient.h
diff --git a/third_party/WebKit/public/web/WebWidgetClient.h b/third_party/WebKit/public/web/WebWidgetClient.h
index 6b0db4d115f503bf5a39ea778892040c5aceff70..5a653c7430add84796d29e188ccad2395bebf81d 100644
--- a/third_party/WebKit/public/web/WebWidgetClient.h
+++ b/third_party/WebKit/public/web/WebWidgetClient.h
@@ -58,6 +58,8 @@ struct WebFloatSize;
class WebWidgetClient {
public:
+ virtual ~WebWidgetClient() {}
+
// Called when a region of the WebWidget needs to be re-painted.
virtual void didInvalidateRect(const WebRect&) {}
@@ -179,9 +181,6 @@ class WebWidgetClient {
WebDragOperationsMask,
const WebImage& dragImage,
const WebPoint& dragImageOffset) {}
-
- protected:
- ~WebWidgetClient() {}
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/web/WebViewClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698