Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: third_party/WebKit/public/web/WebWidgetClient.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)
Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebViewClient.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 class WebNode; 51 class WebNode;
52 class WebString; 52 class WebString;
53 class WebWidget; 53 class WebWidget;
54 struct WebCursorInfo; 54 struct WebCursorInfo;
55 struct WebFloatPoint; 55 struct WebFloatPoint;
56 struct WebFloatRect; 56 struct WebFloatRect;
57 struct WebFloatSize; 57 struct WebFloatSize;
58 58
59 class WebWidgetClient { 59 class WebWidgetClient {
60 public: 60 public:
61 virtual ~WebWidgetClient() {}
62
61 // Called when a region of the WebWidget needs to be re-painted. 63 // Called when a region of the WebWidget needs to be re-painted.
62 virtual void didInvalidateRect(const WebRect&) {} 64 virtual void didInvalidateRect(const WebRect&) {}
63 65
64 // Attempt to initialize compositing view for this widget. If successful, 66 // Attempt to initialize compositing view for this widget. If successful,
65 // returns a valid WebLayerTreeView which is owned by the 67 // returns a valid WebLayerTreeView which is owned by the
66 // WebWidgetClient. 68 // WebWidgetClient.
67 virtual WebLayerTreeView* initializeLayerTreeView() { return nullptr; } 69 virtual WebLayerTreeView* initializeLayerTreeView() { return nullptr; }
68 70
69 // FIXME: Remove all overrides of this. 71 // FIXME: Remove all overrides of this.
70 virtual bool allowsBrokenNullLayerTreeView() const { return false; } 72 virtual bool allowsBrokenNullLayerTreeView() const { return false; }
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // is eanbled. TODO(oshima): Update the comment when the 174 // is eanbled. TODO(oshima): Update the comment when the
173 // migration is completed. 175 // migration is completed.
174 virtual void convertWindowToViewport(WebFloatRect* rect) {} 176 virtual void convertWindowToViewport(WebFloatRect* rect) {}
175 177
176 // Called when a drag-and-drop operation should begin. 178 // Called when a drag-and-drop operation should begin.
177 virtual void startDragging(WebReferrerPolicy, 179 virtual void startDragging(WebReferrerPolicy,
178 const WebDragData&, 180 const WebDragData&,
179 WebDragOperationsMask, 181 WebDragOperationsMask,
180 const WebImage& dragImage, 182 const WebImage& dragImage,
181 const WebPoint& dragImageOffset) {} 183 const WebPoint& dragImageOffset) {}
182
183 protected:
184 ~WebWidgetClient() {}
185 }; 184 };
186 185
187 } // namespace blink 186 } // namespace blink
188 187
189 #endif 188 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/public/web/WebViewClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698