third_party/WebKit/public/web/WebViewClient.h - Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)

Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebViewClient.h

diff --git a/third_party/WebKit/public/web/WebViewClient.h b/third_party/WebKit/public/web/WebViewClient.h

index 41195fd3efaac32f15a34e1917ee28b8391b2f64..3d755f760e84967c4f82f374070c64c95d74c664 100644

--- a/third_party/WebKit/public/web/WebViewClient.h

+++ b/third_party/WebKit/public/web/WebViewClient.h

@@ -281,7 +281,7 @@ class WebViewClient : protected WebWidgetClient {

virtual WebWidgetClient* widgetClient() { return this; }

protected:

- ~WebViewClient() {}

+ ~WebViewClient() override {}

};

} // namespace blink