Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)
Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 WebLayerTreeView* initializeLayerTreeView() override { return nullptr; } 274 WebLayerTreeView* initializeLayerTreeView() override { return nullptr; }
275 WebScreenInfo screenInfo() override { return WebScreenInfo(); } 275 WebScreenInfo screenInfo() override { return WebScreenInfo(); }
276 void setTouchAction(WebTouchAction touchAction) override {} 276 void setTouchAction(WebTouchAction touchAction) override {}
277 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition, 277 void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition,
278 const WebNode& tappedNode, 278 const WebNode& tappedNode,
279 bool pageChanged) override {} 279 bool pageChanged) override {}
280 void show(WebNavigationPolicy) override {} 280 void show(WebNavigationPolicy) override {}
281 virtual WebWidgetClient* widgetClient() { return this; } 281 virtual WebWidgetClient* widgetClient() { return this; }
282 282
283 protected: 283 protected:
284 ~WebViewClient() {} 284 ~WebViewClient() override {}
285 }; 285 };
286 286
287 } // namespace blink 287 } // namespace blink
288 288
289 #endif 289 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/public/web/WebWidgetClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698