third_party/WebKit/Source/web/WebViewFrameWidget.cpp - Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

Issue 2773003002: Make the WebWidgetClient parameter a ref so it's not legal to pass a nullptr. (Closed)

Patch Set: WebViewClient dtor now overrides the virtual dtor in WebWidgetClient. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

index 7b662eba0c922c86733d48886116abb4573dd65f..ed07c0a0b0802c9541bef447b3a3807db4fea7a9 100644

--- a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

@@ -10,10 +10,10 @@

namespace blink {

-WebViewFrameWidget::WebViewFrameWidget(WebWidgetClient* client,

+WebViewFrameWidget::WebViewFrameWidget(WebWidgetClient& client,

WebViewImpl& webView,

WebLocalFrameImpl& mainFrame)

- : m_client(client), m_webView(&webView), m_mainFrame(&mainFrame) {

+ : m_client(&client), m_webView(&webView), m_mainFrame(&mainFrame) {

m_mainFrame->setFrameWidget(this);

m_webView->setCompositorVisibility(true);

}