MD Settings: Allow searching the languages list in "add language" dialog.

MD Settings: Allow searching the languages list in "add language" dialog.

BUG=661342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772873002
Cr-Commit-Position: refs/heads/master@{#459338}
Committed: https://chromium.googlesource.com/chromium/src/+/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390

[dpapad, 2017-03-23 18:50:27]

Description was changed from

==========
MD Settings: Allow searching the languages list in "add language" dialog.

BUG=661342
==========

to

==========
MD Settings: Allow searching the languages list in "add language" dialog.

BUG=661342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-23 18:52:41]

Patchset #1 (id:1) has been deleted

[dpapad, 2017-03-23 19:03:37]

Patchset #1 (id:20001) has been deleted

[dpapad, 2017-03-23 19:10:38]

Patchset #1 (id:40001) has been deleted

[dpapad, 2017-03-23 19:33:51]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:49:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2017-03-23 22:42:19]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 22:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-23 22:47:48]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-03-23 22:47:49]

Screencast at https://bugs.chromium.org/p/chromium/issues/detail?id=661342#c14.

I started adding a test for the add_languages_dialog.js, but then I realized
that the language related tests are disabled
(https://bugs.chromium.org/p/chromium/issues/detail?id=692356), so I stopped
because the test I was about to add would never execute.

I can attempt to add the dialog's test as separate tests, but I am concerned
that
a) We will end up with 3 different tests for languages. The other two are
   test/data/webui/settings/languages_tests.js (disabled)
   test/data/webui/settings/languages_page_browsertest.js (partially disabled)
b) My new test might suffer from the same flakiness, if I start using common
testing infrastructure (language_helper).

So, my conclusion is that we should deflake, cleanup and re-enable exsiting
language-related tests, before adding any new ones.

[Dan Beam, 2017-03-23 23:48:34]

I don't really get the height 350 but ok, lgtm

also, we should make the languages tests use fake browser proxies just like
everywhere else...

[commit-bot: I haz the power, 2017-03-24 00:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:35:25]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-24 01:08:32]

On 2017/03/23 at 23:48:34, dbeam wrote:
> I don't really get the height 350 but ok, lgtm
> 
> also, we should make the languages tests use fake browser proxies just like
everywhere else...

Agreed on the languages tests.

Regarding the dialog's height I think that increasing it is in improvement,
given that we know that this dialog contains a fairly long list of languages.
250px might be sufficient for other dialogs that have a short message (for
example deletion confirmation), but not for this case. We do something similar
for the CDB dialog, which has 600+px height.

[dpapad, 2017-03-24 01:53:37]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:54:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 02:03:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490320417133590,
"parent_rev": "fed5bda99ca38b4e2575614c87e858f51b2a8194", "commit_rev":
"9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390"}

[commit-bot: I haz the power, 2017-03-24 02:04:25]

Description was changed from

==========
MD Settings: Allow searching the languages list in "add language" dialog.

BUG=661342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Allow searching the languages list in "add language" dialog.

BUG=661342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772873002
Cr-Commit-Position: refs/heads/master@{#459338}
Committed:
https://chromium.googlesource.com/chromium/src/+/9493bb90ea9b5cc4c5e91c388912...
==========

[commit-bot: I haz the power, 2017-03-24 02:04:27]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9493bb90ea9b5cc4c5e91c388912...