Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6981)

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.html

Issue 2772873002: MD Settings: Allow searching the languages list in "add language" dialog. (Closed)
Patch Set: Fix test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/add_languages_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.html
diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.html b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
index 332323927da2e95e116c10c370082e63a1459759..4f516726bd09ed3f8d848065712d419c90355368 100644
--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
@@ -1,26 +1,31 @@
<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="languages.html">
+<link rel="import" href="../settings_page/settings_subpage_search.html">
<link rel="import" href="../settings_shared_css.html">
<dom-module id="settings-add-languages-dialog">
<template>
<style include="settings-shared">
- dialog {
- display: flex;
- flex-direction: column;
- }
-
.body {
+ -webkit-padding-end: 0 !important;
display: flex;
flex-direction: column;
- max-height: 250px;
+ height: 350px;
overflow: auto;
}
+ settings-subpage-search {
+ -webkit-padding-end: 24px;
+ }
+
+ iron-list {
+ flex: 1;
+ }
+
.ripple-padding {
/* Create a little extra space for checkbox ink ripple to flow into. */
-webkit-padding-start: 20px;
@@ -29,10 +34,12 @@
<dialog is="cr-dialog" id="dialog" close-text="$i18n{close}">
<div class="title">$i18n{addLanguagesDialogTitle}</div>
<div class="body">
- <!-- TODO(michaelpg): Dynamic language search/filtering. -->
+ <settings-subpage-search label="[[searchLabel]]"
+ on-search-changed="onSearchChanged_" autofocus>
+ </settings-subpage-search>
<iron-list class="ripple-padding" scroll-target="[[$$('.body')]]"
- items="[[getAvailableLanguages_(
- languages.supported, languages.enabled.*)]]">
+ items="[[getLanguages_(
+ languages.supported, languages.enabled.*, filterValue_)]]">
<template>
<paper-checkbox class="list-item" checked="[[willAdd_(item.code)]]"
title$="[[item.nativeDisplayName]]"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/add_languages_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698