Do not suppress HTTP Authenticaiton in WebController.

Do not suppress HTTP Authenticaiton in WebController.

web layer should not make assumptions that chrome handles HTTP
Authentication by showing the dialog. So even if |shouldSuppressDialogs|
value is set to YES, CRWWebController still should ask the delegate to
handle HTTP Authentication.

BUG=702381
Review-Url: https://codereview.chromium.org/2772723006
Cr-Commit-Position: refs/heads/master@{#460130}
Committed: https://chromium.googlesource.com/chromium/src/+/862085fdce1bb084ad57e893e1068a739546122d

[Eugene But (OOO till 7-30), 2017-03-24 22:18:19]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-03-24 22:18:28]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 22:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:59:03]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-03-27 13:00:14]

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.h:352: // Cancels prerendering. Can be called only
for prerender tabs (where
Can you clarify how the 'can only be called for prerender tabs' contract is
enforced?

[Eugene But (OOO till 7-30), 2017-03-27 16:46:50]

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.h:352: // Cancels prerendering. Can be called only
for prerender tabs (where
On 2017/03/27 13:00:13, marq wrote:
> Can you clarify how the 'can only be called for prerender tabs' contract is
> enforced?
It is enforced via DCHECK like in other invariant in Chrome code. Is this
something that you want me to document in the comments? For me this seems pretty
standard way to enforce the contracts.

[marq (ping after 24h), 2017-03-27 17:04:31]

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.h:352: // Cancels prerendering. Can be called only
for prerender tabs (where
On 2017/03/27 16:46:50, Eugene But wrote:
> On 2017/03/27 13:00:13, marq wrote:
> > Can you clarify how the 'can only be called for prerender tabs' contract is
> > enforced?
> It is enforced via DCHECK like in other invariant in Chrome code. Is this
> something that you want me to document in the comments? For me this seems
pretty
> standard way to enforce the contracts.

I was mostly looking for a clearer statement in the comment -- "It is an error
to call this on anything except a prerender tab" as opposed to (say) "Calling
this on a non-prerender tab does nothing".

[Eugene But (OOO till 7-30), 2017-03-27 17:19:07]

PTAL

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab.h (right):

https://codereview.chromium.org/2772723006/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab.h:352: // Cancels prerendering. Can be called only
for prerender tabs (where
On 2017/03/27 17:04:30, marq wrote:
> On 2017/03/27 16:46:50, Eugene But wrote:
> > On 2017/03/27 13:00:13, marq wrote:
> > > Can you clarify how the 'can only be called for prerender tabs' contract
is
> > > enforced?
> > It is enforced via DCHECK like in other invariant in Chrome code. Is this
> > something that you want me to document in the comments? For me this seems
> pretty
> > standard way to enforce the contracts.
> 
> I was mostly looking for a clearer statement in the comment -- "It is an error
> to call this on anything except a prerender tab" as opposed to (say) "Calling
> this on a non-prerender tab does nothing".
Thanks for clarification. Done.

[marq (ping after 24h), 2017-03-28 07:36:14]

lgtm

[Eugene But (OOO till 7-30), 2017-03-28 15:09:06]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:47:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490713746580210,
"parent_rev": "8968cd5170f4a22b1c508ffa3bc240b346c44b1b", "commit_rev":
"862085fdce1bb084ad57e893e1068a739546122d"}

[commit-bot: I haz the power, 2017-03-28 16:48:37]

Description was changed from

==========
Do not suppress HTTP Authenticaiton in WebController.

web layer should not make assumptions that chrome handles HTTP
Authentication by showing the dialog. So even if |shouldSuppressDialogs|
value is set to YES, CRWWebController still should ask the delegate to
handle HTTP Authentication.

BUG=702381
==========

to

==========
Do not suppress HTTP Authenticaiton in WebController.

web layer should not make assumptions that chrome handles HTTP
Authentication by showing the dialog. So even if |shouldSuppressDialogs|
value is set to YES, CRWWebController still should ask the delegate to
handle HTTP Authentication.

BUG=702381

Review-Url: https://codereview.chromium.org/2772723006
Cr-Commit-Position: refs/heads/master@{#460130}
Committed:
https://chromium.googlesource.com/chromium/src/+/862085fdce1bb084ad57e893e106...
==========

[commit-bot: I haz the power, 2017-03-28 16:48:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/862085fdce1bb084ad57e893e106...