ios/web/web_state/ui/crw_web_controller.mm - Issue 2772723006: Do not suppress HTTP Authenticaiton in WebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2772723006: Do not suppress HTTP Authenticaiton in WebController. (Closed)

Patch Set: Updated comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 2d14db8e9356133038ee2ea12474641f5dd1619e..0526fd34e17bb684dd9b6f138e616f8775a3c5d9 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -3298,14 +3298,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

[space.authenticationMethod isEqual:NSURLAuthenticationMethodNTLM] ||

[space.authenticationMethod isEqual:NSURLAuthenticationMethodHTTPDigest]);

- if (self.shouldSuppressDialogs) {

- // TODO(crbug.com/702381): Web Controller should not assume that embedder

- // handles HTTP Authentication by showing the dialog.

- _webStateImpl->OnDialogSuppressed();

- completionHandler(NSURLSessionAuthChallengeRejectProtectionSpace, nil);

- return;

- }

_webStateImpl->OnAuthRequired(

space, challenge.proposedCredential,

base::BindBlock(^(NSString* user, NSString* password) {

« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | no next file » | no next file with comments »