Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2772723003: Revert of Increases default maximum number of audio input & output streams (Closed)

Created:
3 years, 9 months ago by o1ka
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Increases default maximum number of audio input & output streams (patchset #1 id:1 of https://codereview.chromium.org/2632503004/ ) Reason for revert: Speculative revert to identify the cause of Media.AudioRendererAudioGlitches. Should be relanded after we collect enough info to make a conclusion if this CL is a culprit or not. BUG=686689 Original issue's description: > Increases default maximum number of audio input & output streams. > The increase is from 16 to 32. > > BUG=679215 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2632503004 > Cr-Commit-Position: refs/heads/master@{#443589} > Committed: https://chromium.googlesource.com/chromium/src/+/1bb13224524862e5d3be4ac68c6377a4e54c9433 TBR=tommi@chromium.org,henrika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=679215 Review-Url: https://codereview.chromium.org/2772723003 Cr-Commit-Position: refs/heads/master@{#459110} Committed: https://chromium.googlesource.com/chromium/src/+/a7682c8258c2e04621d791d60ba835f35b90cd1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/audio_manager_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
o1ka
Created Revert of Increases default maximum number of audio input & output streams
3 years, 9 months ago (2017-03-23 14:41:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772723003/1
3 years, 9 months ago (2017-03-23 14:42:14 UTC) #3
henrika (OOO until Aug 14)
lgtm
3 years, 9 months ago (2017-03-23 14:44:39 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:27:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7682c8258c2e04621d791d60ba8...

Powered by Google App Engine
This is Rietveld 408576698