Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2632503004: Increases default maximum number of audio input & output streams (Closed)

Created:
3 years, 11 months ago by henrika (OOO until Aug 14)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increases default maximum number of audio input & output streams. The increase is from 16 to 32. BUG=679215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2632503004 Cr-Commit-Position: refs/heads/master@{#443589} Committed: https://chromium.googlesource.com/chromium/src/+/1bb13224524862e5d3be4ac68c6377a4e54c9433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/audio_manager_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
henrika (OOO until Aug 14)
PTAL
3 years, 11 months ago (2017-01-13 15:35:22 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 11 months ago (2017-01-13 15:36:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632503004/1
3 years, 11 months ago (2017-01-13 15:36:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1bb13224524862e5d3be4ac68c6377a4e54c9433
3 years, 11 months ago (2017-01-13 17:11:16 UTC) #10
o1ka
3 years, 9 months ago (2017-03-23 14:41:53 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2772723003/ by olka@chromium.org.

The reason for reverting is: Speculative revert to identify the cause of
Media.AudioRendererAudioGlitches. Should be relanded after we collect enough
info to make a conclusion if this CL is a culprit or not.

BUG=686689.

Powered by Google App Engine
This is Rietveld 408576698