Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2772693002: Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (Closed)

Created:
3 years, 9 months ago by Kunihiko Sakamoto
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file. (patchset #2 id:20001 of https://codereview.chromium.org/2759593003/ ) Reason for revert: Broke DEPS auto rollers. https://bugs.chromium.org/p/chromium/issues/detail?id=704405 Original issue's description: > Don't require DEPS OWNERS when moving lines around in a DEPS file. > > As a bonus, less regex than before and also correctly handles the > '!' prefix in DEPS files now. > > BUG=702851 > > Review-Url: https://codereview.chromium.org/2759593003 > Cr-Commit-Position: refs/heads/master@{#458928} > Committed: https://chromium.googlesource.com/chromium/src/+/63dd720c98271a15da8e483906dc92c3d0603e7d TBR=dpranke@chromium.org,dcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702851 Review-Url: https://codereview.chromium.org/2772693002 Cr-Commit-Position: refs/heads/master@{#459004} Committed: https://chromium.googlesource.com/chromium/src/+/b89c4320456a8a5b52c5b4fb4cee7421081f4616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -116 lines) Patch
M PRESUBMIT.py View 4 chunks +25 lines, -46 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +33 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Kunihiko Sakamoto
Created Revert of Don't require DEPS OWNERS when moving lines around in a DEPS file.
3 years, 9 months ago (2017-03-23 04:38:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772693002/1
3 years, 9 months ago (2017-03-23 04:38:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 04:39:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b89c4320456a8a5b52c5b4fb4cee...

Powered by Google App Engine
This is Rietveld 408576698