Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2759593003: Don't require DEPS OWNERS when moving lines around in a DEPS file. (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't require DEPS OWNERS when moving lines around in a DEPS file. As a bonus, less regex than before and also correctly handles the '!' prefix in DEPS files now. BUG=702851 Review-Url: https://codereview.chromium.org/2759593003 Cr-Commit-Position: refs/heads/master@{#458928} Committed: https://chromium.googlesource.com/chromium/src/+/63dd720c98271a15da8e483906dc92c3d0603e7d

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -56 lines) Patch
M PRESUBMIT.py View 1 4 chunks +45 lines, -24 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +69 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dcheng
Depends on https://chromium-review.googlesource.com/c/456755/.
3 years, 9 months ago (2017-03-18 01:15:17 UTC) #3
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-22 01:28:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759593003/20001
3 years, 9 months ago (2017-03-22 23:03:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/63dd720c98271a15da8e483906dc92c3d0603e7d
3 years, 9 months ago (2017-03-22 23:27:02 UTC) #9
Kunihiko Sakamoto
3 years, 9 months ago (2017-03-23 04:38:29 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2772693002/ by ksakamoto@chromium.org.

The reason for reverting is: Broke DEPS auto rollers.
https://bugs.chromium.org/p/chromium/issues/detail?id=704405.

Powered by Google App Engine
This is Rietveld 408576698