Split ui.lib to avoid hitting 4 GB limit

Split ui.lib to avoid hitting 4 GB limit

In some build configurations on Windows (official build, goma with
symbol_level = 2) ui.lib can grow to about 4 GB which leads to cryptic
build failures. Rather than trying to carefully calculate which
configurations need to split ui.lib it is simpler to just always
split it on Windows. There is no real 'cost' for doing this other than
some potential confusion when developers look at the build internals.

Instead of building obj\chrome\browser\ui\ui.lib the files built will
be obj\chrome\browser\ui\ui_?.lib where '?' is 0-4.

This also fixes up some errors in the comments for the previous
change which covered browser.lib.

With this change the next largest .lib file created when building the
'chrome' target is extensions.lib at 1.9 GB, which is a lot of safety
margin (limit is 4 GB for VS 2015 and 2017).

BUG=701862
Review-Url: https://codereview.chromium.org/2772583003
Cr-Commit-Position: refs/heads/master@{#459296}
Committed: https://chromium.googlesource.com/chromium/src/+/07b41129c2000598bba17282207731e8946a4031

[brucedawson, 2017-03-23 18:56:12]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 18:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:33:23]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-03-23 21:10:48]

brucedawson@chromium.org changed reviewers:
+ brettw@chromium.org

[brucedawson, 2017-03-23 21:10:49]

Last change to guarantee we don't hit .lib size limits even on goma builds.
PTAL.

[brettw, 2017-03-23 22:06:58]

lgtm

[brucedawson, 2017-03-24 00:17:01]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:17:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:21:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490314621118960, "parent_rev":
"24b025e73e8ae9efc3f06fd98467dcdb8b1c00eb", "commit_rev":
"07b41129c2000598bba17282207731e8946a4031"}

[commit-bot: I haz the power, 2017-03-24 00:23:25]

Description was changed from

==========
Split ui.lib to avoid hitting 4 GB limit

In some build configurations on Windows (official build, goma with
symbol_level = 2) ui.lib can grow to about 4 GB which leads to cryptic
build failures. Rather than trying to carefully calculate which
configurations need to split ui.lib it is simpler to just always
split it on Windows. There is no real 'cost' for doing this other than
some potential confusion when developers look at the build internals.

Instead of building obj\chrome\browser\ui\ui.lib the files built will
be obj\chrome\browser\ui\ui_?.lib where '?' is 0-4.

This also fixes up some errors in the comments for the previous
change which covered browser.lib.

With this change the next largest .lib file created when building the
'chrome' target is extensions.lib at 1.9 GB, which is a lot of safety
margin (limit is 4 GB for VS 2015 and 2017).

BUG=701862
==========

to

==========
Split ui.lib to avoid hitting 4 GB limit

In some build configurations on Windows (official build, goma with
symbol_level = 2) ui.lib can grow to about 4 GB which leads to cryptic
build failures. Rather than trying to carefully calculate which
configurations need to split ui.lib it is simpler to just always
split it on Windows. There is no real 'cost' for doing this other than
some potential confusion when developers look at the build internals.

Instead of building obj\chrome\browser\ui\ui.lib the files built will
be obj\chrome\browser\ui\ui_?.lib where '?' is 0-4.

This also fixes up some errors in the comments for the previous
change which covered browser.lib.

With this change the next largest .lib file created when building the
'chrome' target is extensions.lib at 1.9 GB, which is a lot of safety
margin (limit is 4 GB for VS 2015 and 2017).

BUG=701862

Review-Url: https://codereview.chromium.org/2772583003
Cr-Commit-Position: refs/heads/master@{#459296}
Committed:
https://chromium.googlesource.com/chromium/src/+/07b41129c2000598bba172822077...
==========

[commit-bot: I haz the power, 2017-03-24 00:23:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07b41129c2000598bba172822077...