Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6829)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2772583003: Split ui.lib to avoid hitting 4 GB limit (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 1b9a0fc6879aa46cd19582ad97990318033b77c7..9c6176c8e4445e318719d85b6b6e5028af580625 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -26,9 +26,11 @@ config("ui_warnings") {
# Use a static library here because many test binaries depend on this but don't
# require many files from it. This makes linking more efficient.
split_static_library("ui") {
- # Split into multiple static libraries on Windows official builds, where we
- # run into a 2GB max size limit.
- if (is_win && is_official_build) {
+ # Split into multiple static libraries on Windows builds. We have hit size
+ # limits on Windows official builds and on goma builds when symbol_level = 2
+ # is selected. Always splitting on Windows builds is simpler than trying to
+ # perfectly calculate the scenarios where it is required.
+ if (is_win) {
split_count = 5
} else {
split_count = 1
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698