Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: ios/chrome/browser/reading_list/BUILD.gn

Issue 2772373004: Fix deps reading_list_remover_helper -> dom_distiller (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("reading_list") { 5 source_set("reading_list") {
6 configs += [ "//build/config/compiler:enable_arc" ] 6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 7 sources = [
8 "favicon_web_state_dispatcher_impl.h", 8 "favicon_web_state_dispatcher_impl.h",
9 "favicon_web_state_dispatcher_impl.mm", 9 "favicon_web_state_dispatcher_impl.mm",
10 "offline_url_utils.cc", 10 "offline_url_utils.cc",
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 source_set("reading_list_remover") { 59 source_set("reading_list_remover") {
60 sources = [ 60 sources = [
61 "reading_list_remover_helper.cc", 61 "reading_list_remover_helper.cc",
62 "reading_list_remover_helper.h", 62 "reading_list_remover_helper.h",
63 ] 63 ]
64 deps = [ 64 deps = [
65 "//base", 65 "//base",
66 "//components/reading_list/core", 66 "//components/reading_list/core",
67 "//ios/chrome/browser/browser_state", 67 "//ios/chrome/browser/browser_state",
68 ] 68 ]
69 public_deps = [
sdefresne 2017/03/28 08:57:21 lgtm, but can you add a comment that this is becau
Olivier 2017/03/28 11:46:51 Done.
70 "//ios/chrome/browser/dom_distiller",
71 ]
69 } 72 }
70 73
71 source_set("unit_tests") { 74 source_set("unit_tests") {
72 configs += [ "//build/config/compiler:enable_arc" ] 75 configs += [ "//build/config/compiler:enable_arc" ]
73 testonly = true 76 testonly = true
74 sources = [ 77 sources = [
75 "favicon_web_state_dispatcher_impl_unittest.mm", 78 "favicon_web_state_dispatcher_impl_unittest.mm",
76 "offline_url_utils_unittest.cc", 79 "offline_url_utils_unittest.cc",
77 "reading_list_web_state_observer_unittest.mm", 80 "reading_list_web_state_observer_unittest.mm",
78 "url_downloader_unittest.mm", 81 "url_downloader_unittest.mm",
79 ] 82 ]
80 deps = [ 83 deps = [
81 ":reading_list", 84 ":reading_list",
82 "//base", 85 "//base",
83 "//base/test:test_support", 86 "//base/test:test_support",
84 "//components/favicon/ios", 87 "//components/favicon/ios",
85 "//components/reading_list/core", 88 "//components/reading_list/core",
86 "//ios/chrome/browser", 89 "//ios/chrome/browser",
87 "//ios/chrome/browser/browser_state:test_support", 90 "//ios/chrome/browser/browser_state:test_support",
88 "//ios/chrome/browser/dom_distiller", 91 "//ios/chrome/browser/dom_distiller",
89 "//ios/testing:ios_test_support", 92 "//ios/testing:ios_test_support",
90 "//ios/web", 93 "//ios/web",
91 "//ios/web:reload_type", 94 "//ios/web:reload_type",
92 "//ios/web:test_support", 95 "//ios/web:test_support",
93 "//net", 96 "//net",
94 "//testing/gtest", 97 "//testing/gtest",
95 "//url", 98 "//url",
96 ] 99 ]
97 } 100 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698