Revert of Add StyleDifference::needsVisualRectUpdate

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 543 matching lines @@
       diff.setNeedsFullLayout();
     else
       diff.setNeedsPositionedMovementLayout();
   }
 
   if (diffNeedsPaintInvalidationSubtree(other))
     diff.setNeedsPaintInvalidationSubtree();
   else if (diffNeedsPaintInvalidationObject(other))
     diff.setNeedsPaintInvalidationObject();
 
-  if (diffNeedsVisualRectUpdate(other))
-    diff.setNeedsVisualRectUpdate();
+  updatePropertySpecificDifferences(other, diff);
 
-  // This needs to be at last, because it may depend on conditions in diff
-  // computed above.
-  updatePropertySpecificDifferences(other, diff);
+  // The following condition needs to be at last, because it may depend on
+  // conditions in diff computed above.
+  if (scrollAnchorDisablingPropertyChanged(other, diff))
+    diff.setScrollAnchorDisablingPropertyChanged();
 
   // Cursors are not checked, since they will be set appropriately in response
   // to mouse events, so they don't need to cause any paint invalidation or
   // layout.
 
   // Animations don't need to be checked either. We always set the new style on
   // the layoutObject, so we will get a chance to fire off the resulting
   // transition properly.
 
   return diff;
@@ skipping 417 matching lines @@
     for (const AtomicString& property :
          *value->customInvalidationProperties()) {
       if (!dataEquivalent(getVariable(property), other.getVariable(property)))
         return true;
     }
   }
 
   return false;
 }
 
-// This doesn't include conditions needing layout or overflow recomputation
-// which implies visual rect update.
-bool ComputedStyle::diffNeedsVisualRectUpdate(
-    const ComputedStyle& other) const {
-  // Visual rect is empty if visibility is hidden.
-  if (visibility() != other.visibility())
-    return true;
-
-  // Need to update visual rect of the resizer.
-  if (resize() != other.resize())
-    return true;
-
-  return false;
-}
-
 void ComputedStyle::updatePropertySpecificDifferences(
     const ComputedStyle& other,
     StyleDifference& diff) const {
   if (m_box->zIndex() != other.m_box->zIndex() ||
       isStackingContext() != other.isStackingContext())
     diff.setZIndexChanged();
 
   if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
     if (!transformDataEquivalent(other) ||
         m_rareNonInheritedData->m_perspective !=
@@ skipping 74 matching lines @@
       diff.setTextDecorationOrColorChanged();
     }
   }
 
   bool hasClip = hasOutOfFlowPosition() && !m_visual->hasAutoClip;
   bool otherHasClip =
       other.hasOutOfFlowPosition() && !other.m_visual->hasAutoClip;
   if (hasClip != otherHasClip ||
       (hasClip && m_visual->clip != other.m_visual->clip))
     diff.setCSSClipChanged();
-
-  if (scrollAnchorDisablingPropertyChanged(other, diff))
-    diff.setScrollAnchorDisablingPropertyChanged();
 }
 
 void ComputedStyle::addPaintImage(StyleImage* image) {
   if (!m_rareNonInheritedData.access()->m_paintImages) {
     m_rareNonInheritedData.access()->m_paintImages =
         WTF::makeUnique<Vector<Persistent<StyleImage>>>();
   }
   m_rareNonInheritedData.access()->m_paintImages->push_back(image);
 }
 
@@ skipping 1368 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return roundForImpreciseConversion<int>(fvalue / zoomFactor);
 }
 
 }  // namespace blink