Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2772343004: [Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in Shutdown() (Closed)

Created:
3 years, 9 months ago by imcheng
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3053
Project:
chromium
Visibility:
Public.

Description

[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in Shutdown() Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the dependency from the former to the latter should be disposed in its Shutdown() method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs to be reset in Shutdown(). BUG=705216 Review-Url: https://codereview.chromium.org/2774383003 Cr-Commit-Position: refs/heads/master@{#459900} (cherry picked from commit 6812c7313dd67fcfad6f95d4b5a91cf7dcfda06a) Review-Url: https://codereview.chromium.org/2772343004 . Cr-Commit-Position: refs/branch-heads/3053@{#3} Cr-Branched-From: bba05f44fe583ffa69c22d36f91aaebe0ceea282-refs/heads/master@{#459685} Committed: https://chromium.googlesource.com/chromium/src/+/d0fef1556f8a954735cb20f8d90d5b59dba32458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/media/router/media_router_ui_service.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_ui_service.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
3 years, 9 months ago (2017-03-27 22:43:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0fef1556f8a954735cb20f8d90d5b59dba32458.

Powered by Google App Engine
This is Rietveld 408576698