[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in Shutdown()

[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be reset in Shutdown().

BUG=705216
Review-Url: https://codereview.chromium.org/2774383003
Cr-Commit-Position: refs/heads/master@{#459900}
Committed: https://chromium.googlesource.com/chromium/src/+/6812c7313dd67fcfad6f95d4b5a91cf7dcfda06a

[takumif, 2017-03-27 18:53:43]

Description was changed from

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

BUG=705216
==========

to

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to the MRMojoImpl, so it needs to be
reset in Shutdown().

BUG=705216
==========

[takumif, 2017-03-27 18:58:11]

Description was changed from

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to the MRMojoImpl, so it needs to be
reset in Shutdown().

BUG=705216
==========

to

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to the MRMojoImpl, so it needs to be
reset in Shutdown().

BUG=705216
==========

[takumif, 2017-03-27 18:58:48]

Description was changed from

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to the MRMojoImpl, so it needs to be
reset in Shutdown().

BUG=705216
==========

to

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be
reset in Shutdown().

BUG=705216
==========

[takumif, 2017-03-27 18:59:02]

Description was changed from

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be
reset in Shutdown().

BUG=705216
==========

to

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be reset in Shutdown().

BUG=705216
==========

[takumif, 2017-03-27 18:59:58]

takumif@chromium.org changed reviewers:
+ imcheng@chromium.org

[takumif, 2017-03-27 18:59:59]

Please take a look, thanks!

[takumif, 2017-03-27 19:10:12]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:11:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:11:10]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[imcheng, 2017-03-27 20:51:06]

lgtm

https://codereview.chromium.org/2774383003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router_ui_service.cc (right):

https://codereview.chromium.org/2774383003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router_ui_service.cc:15:
base::MakeUnique<MediaRouterActionController>(profile)) {}
nit: new MediaRouteActionController(profile)

[takumif, 2017-03-27 21:04:12]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 21:04:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:47:45]

Dry run: This issue passed the CQ dry run.

[takumif, 2017-03-27 21:49:08]

https://codereview.chromium.org/2774383003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router_ui_service.cc (right):

https://codereview.chromium.org/2774383003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router_ui_service.cc:15:
base::MakeUnique<MediaRouterActionController>(profile)) {}
On 2017/03/27 20:51:06, imcheng wrote:
> nit: new MediaRouteActionController(profile)

Done.

[takumif, 2017-03-27 21:49:13]

The CQ bit was checked by takumif@chromium.org

[takumif, 2017-03-27 21:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2774383003/#ps20001
(title: "Address Derek's comment")

[commit-bot: I haz the power, 2017-03-27 21:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:12:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490651353442580,
"parent_rev": "18386cd771d77f28621fd74f5043c8e0526e92a4", "commit_rev":
"6812c7313dd67fcfad6f95d4b5a91cf7dcfda06a"}

[commit-bot: I haz the power, 2017-03-27 22:13:54]

Description was changed from

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be reset in Shutdown().

BUG=705216
==========

to

==========
[Media Router] Make MRUIService dispose its dependencies on MRMojoImpl in
Shutdown()

Both MediaRouterUIService and MediaRouterMojoImpl are KeyedServices, and the
dependency from the former to the latter should be disposed in its Shutdown()
method. |action_controller_| is an observer to MediaRouterMojoImpl, so it needs
to be reset in Shutdown().

BUG=705216

Review-Url: https://codereview.chromium.org/2774383003
Cr-Commit-Position: refs/heads/master@{#459900}
Committed:
https://chromium.googlesource.com/chromium/src/+/6812c7313dd67fcfad6f95d4b5a9...
==========

[commit-bot: I haz the power, 2017-03-27 22:13:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6812c7313dd67fcfad6f95d4b5a9...