Android: Remove GetApplicationContext part 1

base/android/java/src/org/chromium/base/BuildInfo.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.base;
 
 import android.content.Context;
 import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
@@ skipping 26 matching lines @@
         return Build.BRAND;
     }
 
     @CalledByNative
     public static String getAndroidBuildId() {
         return Build.ID;
     }
 
     /**
      * @return The build fingerprint for the current Android install.  The value is truncated to a
-     *         128 characters as this is used for crash and UMA reporting, which should avoid huge
-     *         strings.
+     * 128 characters as this is used for crash and UMA reporting, which should avoid huge
+     * strings.
      */
     @CalledByNative
     public static String getAndroidBuildFingerprint() {
         return Build.FINGERPRINT.substring(
                 0, Math.min(Build.FINGERPRINT.length(), MAX_FINGERPRINT_LENGTH));
     }
 
     @CalledByNative
     public static String getDeviceManufacturer() {
         return Build.MANUFACTURER;
     }
 
     @CalledByNative
     public static String getDeviceModel() {
         return Build.MODEL;
     }
 
     @CalledByNative
-    public static String getGMSVersionCode(Context context) {
+    public static String getGMSVersionCode() {
         String msg = "gms versionCode not available.";
         try {
-            PackageManager packageManager = context.getPackageManager();
+            PackageManager packageManager =
+                    ContextUtils.getApplicationContext().getPackageManager();
             PackageInfo packageInfo = packageManager.getPackageInfo("com.google.android.gms", 0);
             msg = Integer.toString(packageInfo.versionCode);
         } catch (NameNotFoundException e) {
             Log.d(TAG, "GMS package is not found.", e);
         }
         return msg;
     }
 
     @CalledByNative
-    public static String getPackageVersionCode(Context context) {
+    public static String getPackageVersionCode() {
         String msg = "versionCode not available.";
         try {
-            PackageManager pm = context.getPackageManager();
-            PackageInfo pi = pm.getPackageInfo(context.getPackageName(), 0);
+            PackageManager pm = ContextUtils.getApplicationContext().getPackageManager();

[estevenson, 2017/03/27 21:00:54]

optional nit: might be a little nicer to store context here instead of making
two calls to ContextUtils.getApplicationContext()?

[Peter Wen, 2017/03/27 22:31:06]

Modified it a little bit by calling getPackageName() locally. Proguard will
optimize away ContextUtils, so I'd prefer to use it directly where it is
required, but short hands are good when it's used a lot.

Might think about renaming to ContextUtils.getAppContext() instead.

+            PackageInfo pi =
+                    pm.getPackageInfo(ContextUtils.getApplicationContext().getPackageName(), 0);
             msg = "";
             if (pi.versionCode > 0) {
                 msg = Integer.toString(pi.versionCode);
             }
         } catch (NameNotFoundException e) {
             Log.d(TAG, msg);
         }
         return msg;
     }
 
     @CalledByNative
-    public static String getPackageVersionName(Context context) {
+    public static String getPackageVersionName() {
         String msg = "versionName not available";
         try {
-            PackageManager pm = context.getPackageManager();
-            PackageInfo pi = pm.getPackageInfo(context.getPackageName(), 0);
+            PackageManager pm = ContextUtils.getApplicationContext().getPackageManager();
+            PackageInfo pi =
+                    pm.getPackageInfo(ContextUtils.getApplicationContext().getPackageName(), 0);
             msg = "";
             if (pi.versionName != null) {
                 msg = pi.versionName;
             }
         } catch (NameNotFoundException e) {
             Log.d(TAG, msg);
         }
         return msg;
     }
 
     @CalledByNative
-    public static String getPackageLabel(Context context) {
+    public static String getPackageLabel() {
         // Third-party code does disk read on the getApplicationInfo call. http://crbug.com/614343
         StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
         try {
-            PackageManager packageManager = context.getPackageManager();
-            ApplicationInfo appInfo = packageManager.getApplicationInfo(context.getPackageName(),
+            PackageManager packageManager =
+                    ContextUtils.getApplicationContext().getPackageManager();
+            ApplicationInfo appInfo = packageManager.getApplicationInfo(
+                    ContextUtils.getApplicationContext().getPackageName(),
                     PackageManager.GET_META_DATA);
             CharSequence label = packageManager.getApplicationLabel(appInfo);
-            return  label != null ? label.toString() : "";
+            return label != null ? label.toString() : "";
         } catch (NameNotFoundException e) {
             return "";
         } finally {
             StrictMode.setThreadPolicy(oldPolicy);
         }
     }
 
     @CalledByNative
-    public static String getPackageName(Context context) {
-        String packageName = context != null ? context.getPackageName() : null;
-        return packageName != null ? packageName : "";
+    public static String getPackageName() {
+        if (ContextUtils.getApplicationContext() == null) {
+            return "";
+        }
+        return ContextUtils.getApplicationContext().getPackageName();
     }
 
     @CalledByNative
     public static String getBuildType() {
         return Build.TYPE;
     }
 
     /**
      * Check if this is a debuggable build of Android. Use this to enable developer-only features.
      */
@@ skipping 23 matching lines @@
 
     /**
      * @return Whether the current app targets the SDK for at least O
      */
     public static boolean targetsAtLeastO(Context appContext) {
         return isAtLeastO()
                 && appContext.getApplicationInfo().targetSdkVersion
                 == Build.VERSION_CODES.CUR_DEVELOPMENT;
     }
 }