Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2772343002: cc: Fix DisplayScheduler:pending_swaps tracing. (Closed)

Created:
3 years, 9 months ago by Daniele Castagna
Modified:
3 years, 9 months ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix DisplayScheduler:pending_swaps tracing. Similar to AsyncSwapBuffer tracing, DisplayScheduler:pending_swaps tracing was assuming at most one pending buffer would be in flight. This was creating a misleading trace. This CL removes that assumption, similar to what we did in crrev.com/2770113003 for AsyncSwapBuffer. BUG=705196 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2772343002 Cr-Commit-Position: refs/heads/master@{#459812} Committed: https://chromium.googlesource.com/chromium/src/+/41769318b72c3ca03f8da51ada352ac998672ee8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove aysnc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M cc/surfaces/display_scheduler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Daniele Castagna
3 years, 9 months ago (2017-03-27 15:58:35 UTC) #5
reveman
lgtm % nit https://codereview.chromium.org/2772343002/diff/1/cc/surfaces/display_scheduler.h File cc/surfaces/display_scheduler.h (right): https://codereview.chromium.org/2772343002/diff/1/cc/surfaces/display_scheduler.h#newcode87 cc/surfaces/display_scheduler.h:87: int next_async_swap_id_; nit: not sure we ...
3 years, 9 months ago (2017-03-27 16:03:52 UTC) #6
Daniele Castagna
https://codereview.chromium.org/2772343002/diff/1/cc/surfaces/display_scheduler.h File cc/surfaces/display_scheduler.h (right): https://codereview.chromium.org/2772343002/diff/1/cc/surfaces/display_scheduler.h#newcode87 cc/surfaces/display_scheduler.h:87: int next_async_swap_id_; On 2017/03/27 at 16:03:52, reveman wrote: > ...
3 years, 9 months ago (2017-03-27 16:08:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772343002/20001
3 years, 9 months ago (2017-03-27 17:06:54 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 17:17:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41769318b72c3ca03f8da51ada35...

Powered by Google App Engine
This is Rietveld 408576698