Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: cc/surfaces/display_scheduler.cc

Issue 2772343002: cc: Fix DisplayScheduler:pending_swaps tracing. (Closed)
Patch Set: Remove aysnc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display_scheduler.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/display_scheduler.h" 5 #include "cc/surfaces/display_scheduler.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/trace_event/trace_event.h" 11 #include "base/trace_event/trace_event.h"
12 #include "cc/output/output_surface.h" 12 #include "cc/output/output_surface.h"
13 13
14 namespace cc { 14 namespace cc {
15 15
16 DisplayScheduler::DisplayScheduler(base::SingleThreadTaskRunner* task_runner, 16 DisplayScheduler::DisplayScheduler(base::SingleThreadTaskRunner* task_runner,
17 int max_pending_swaps) 17 int max_pending_swaps)
18 : client_(nullptr), 18 : client_(nullptr),
19 begin_frame_source_(nullptr), 19 begin_frame_source_(nullptr),
20 task_runner_(task_runner), 20 task_runner_(task_runner),
21 inside_surface_damaged_(false), 21 inside_surface_damaged_(false),
22 visible_(false), 22 visible_(false),
23 output_surface_lost_(false), 23 output_surface_lost_(false),
24 root_surface_resources_locked_(true), 24 root_surface_resources_locked_(true),
25 inside_begin_frame_deadline_interval_(false), 25 inside_begin_frame_deadline_interval_(false),
26 needs_draw_(false), 26 needs_draw_(false),
27 expecting_root_surface_damage_because_of_resize_(false), 27 expecting_root_surface_damage_because_of_resize_(false),
28 all_active_child_surfaces_ready_to_draw_(false), 28 all_active_child_surfaces_ready_to_draw_(false),
29 next_swap_id_(1),
29 pending_swaps_(0), 30 pending_swaps_(0),
30 max_pending_swaps_(max_pending_swaps), 31 max_pending_swaps_(max_pending_swaps),
31 observing_begin_frame_source_(false), 32 observing_begin_frame_source_(false),
32 root_surface_damaged_(false), 33 root_surface_damaged_(false),
33 expect_damage_from_root_surface_(false), 34 expect_damage_from_root_surface_(false),
34 weak_ptr_factory_(this) { 35 weak_ptr_factory_(this) {
35 begin_frame_deadline_closure_ = base::Bind( 36 begin_frame_deadline_closure_ = base::Bind(
36 &DisplayScheduler::OnBeginFrameDeadline, weak_ptr_factory_.GetWeakPtr()); 37 &DisplayScheduler::OnBeginFrameDeadline, weak_ptr_factory_.GetWeakPtr());
37 } 38 }
38 39
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 void DisplayScheduler::DidFinishFrame(bool did_draw) { 366 void DisplayScheduler::DidFinishFrame(bool did_draw) {
366 // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|. 367 // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
367 BeginFrameAck ack(current_begin_frame_args_.source_id, 368 BeginFrameAck ack(current_begin_frame_args_.source_id,
368 current_begin_frame_args_.sequence_number, 369 current_begin_frame_args_.sequence_number,
369 current_begin_frame_args_.sequence_number, 0, did_draw); 370 current_begin_frame_args_.sequence_number, 0, did_draw);
370 begin_frame_source_->DidFinishFrame(this, ack); 371 begin_frame_source_->DidFinishFrame(this, ack);
371 } 372 }
372 373
373 void DisplayScheduler::DidSwapBuffers() { 374 void DisplayScheduler::DidSwapBuffers() {
374 pending_swaps_++; 375 pending_swaps_++;
375 TRACE_EVENT_ASYNC_BEGIN1("cc", "DisplayScheduler:pending_swaps", this, 376 uint32_t swap_id = next_swap_id_++;
376 "pending_frames", pending_swaps_); 377 TRACE_EVENT_ASYNC_BEGIN0("cc", "DisplayScheduler:pending_swaps", swap_id);
377 } 378 }
378 379
379 void DisplayScheduler::DidReceiveSwapBuffersAck() { 380 void DisplayScheduler::DidReceiveSwapBuffersAck() {
381 uint32_t swap_id = next_swap_id_ - pending_swaps_;
380 pending_swaps_--; 382 pending_swaps_--;
381 TRACE_EVENT_ASYNC_END1("cc", "DisplayScheduler:pending_swaps", this, 383 TRACE_EVENT_ASYNC_END0("cc", "DisplayScheduler:pending_swaps", swap_id);
382 "pending_frames", pending_swaps_);
383 ScheduleBeginFrameDeadline(); 384 ScheduleBeginFrameDeadline();
384 } 385 }
385 386
386 } // namespace cc 387 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/display_scheduler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698