Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2772103002: [Payments] Desktop: never return false in incognito mode for canMakePayment (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tfarina, jam, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Desktop: never return false in incognito mode for canMakePayment BUG=704675 TEST=browser_tests Review-Url: https://codereview.chromium.org/2772103002 Cr-Commit-Position: refs/heads/master@{#459570} Committed: https://chromium.googlesource.com/chromium/src/+/f39f46dcb8679cf14ccd7ff0cf205de49edea458

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
Mathieu
Hi, PTAL!
3 years, 9 months ago (2017-03-24 19:57:08 UTC) #2
please use gerrit instead
lgtm
3 years, 9 months ago (2017-03-24 20:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772103002/1
3 years, 9 months ago (2017-03-24 20:14:19 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 22:09:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f39f46dcb8679cf14ccd7ff0cf20...

Powered by Google App Engine
This is Rietveld 408576698